public inbox for archer@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Keith Seitz <keiths@redhat.com>
Cc: archer@sourceware.org
Subject: Re: Stop the Insanity! Linespec Rewrite
Date: Sat, 03 Mar 2012 02:36:00 -0000	[thread overview]
Message-ID: <8762em9zrw.fsf@fleche.redhat.com> (raw)
In-Reply-To: <4F514C89.3000406@redhat.com> (Keith Seitz's message of "Fri, 02 Mar 2012 14:41:13 -0800")

Tom> From reading the code I had a feeling that a leading ":" wasn't handled
Tom> properly.  So I tried it, and `b ::foo' causes an internal error.

Keith> Doh! I can't believe there is no existing test for that!

It's always funny what is in there and what is not.
The test suite caught a lot of stuff for me during my linespec hacking.
But then sometimes you trip across a funny hole like this...

Keith> For example, you cannot do: "break
Keith> klass::'operator +'" anymore.

Tom> What is the issue with this one?

Keith> Not much, really. I could probably implement something to do it, but I
Keith> really view this whole quoting issue as a workaround for bugs in the
Keith> old linespec.c We don't/shouldn't really need that from here on out.

I remembered now -- this one has quotes in the middle of a token.
I agree, we don't want to deal with that unless there is a lot of
push-back.

Tom

  reply	other threads:[~2012-03-03  2:36 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-02  1:14 Keith Seitz
2012-03-02 17:00 ` Tom Tromey
2012-03-02 22:41   ` Keith Seitz
2012-03-03  2:36     ` Tom Tromey [this message]
2012-03-02 19:07 ` [Archer] " Joel Brobecker
2012-03-02 22:49   ` Keith Seitz
2012-03-06 17:40     ` [Archer] " Joel Brobecker
2012-03-06 19:08       ` Keith Seitz
2012-03-06 19:36         ` Keith Seitz
2012-03-06 21:50           ` [Archer] " Joel Brobecker
2012-03-07  0:11             ` [Archer] " Joel Brobecker
2012-03-07  1:08               ` Keith Seitz
2012-03-07  1:26                 ` [Archer] " Joel Brobecker
2012-03-07 14:39                   ` Tom Tromey
2012-03-07 15:01                     ` Tom Tromey
2012-03-07 15:39                       ` [Archer] " Joel Brobecker
2012-03-07 16:06                         ` Tom Tromey
2012-03-07 21:19                           ` Joel Brobecker
2012-03-07 21:11                         ` [Archer] " Keith Seitz
2012-03-08  3:02                           ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8762em9zrw.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=archer@sourceware.org \
    --cc=keiths@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).