From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6185 invoked by alias); 3 Mar 2012 02:36:39 -0000 Mailing-List: contact archer-help@sourceware.org; run by ezmlm Sender: Precedence: bulk List-Post: List-Help: List-Subscribe: List-Id: Received: (qmail 6104 invoked by uid 22791); 3 Mar 2012 02:36:38 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org From: Tom Tromey To: Keith Seitz Cc: archer@sourceware.org Subject: Re: Stop the Insanity! Linespec Rewrite References: <4F501EC1.3050104@redhat.com> <874nu7c51b.fsf@fleche.redhat.com> <4F514C89.3000406@redhat.com> Date: Sat, 03 Mar 2012 02:36:00 -0000 In-Reply-To: <4F514C89.3000406@redhat.com> (Keith Seitz's message of "Fri, 02 Mar 2012 14:41:13 -0800") Message-ID: <8762em9zrw.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.94 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2012-q1/txt/msg00016.txt.bz2 Tom> From reading the code I had a feeling that a leading ":" wasn't handled Tom> properly. So I tried it, and `b ::foo' causes an internal error. Keith> Doh! I can't believe there is no existing test for that! It's always funny what is in there and what is not. The test suite caught a lot of stuff for me during my linespec hacking. But then sometimes you trip across a funny hole like this... Keith> For example, you cannot do: "break Keith> klass::'operator +'" anymore. Tom> What is the issue with this one? Keith> Not much, really. I could probably implement something to do it, but I Keith> really view this whole quoting issue as a workaround for bugs in the Keith> old linespec.c We don't/shouldn't really need that from here on out. I remembered now -- this one has quotes in the middle of a token. I agree, we don't want to deal with that unless there is a lot of push-back. Tom