From: Paul Pluzhnikov <ppluzhnikov@google.com>
To: Richard Ward <richard.j.ward1@googlemail.com>
Cc: archer@sourceware.org, Tom Tromey <tromey@redhat.com>
Subject: Re: How to distinguish inheritance from containment?
Date: Wed, 01 Jul 2009 21:05:00 -0000 [thread overview]
Message-ID: <8ac60eac0907011405r6013eb17q4afd0d98c740bb5a@mail.gmail.com> (raw)
In-Reply-To: <4A4BCC63.5020407@googlemail.com>
On Wed, Jul 1, 2009 at 1:51 PM, Richard
Ward<richard.j.ward1@googlemail.com> wrote:
> I sent a patch to archer that did just that about two weeks ago, if you want
> it (not that it take that long to write one yourself). It had "Info about
> base class in gdb.Type" in the subject line.
Ah, missed it the first time. The patch looks good to me, except I think
"inherited" is clearer than "base_class". If you don't like "inherited",
perhaps "is_base_class" ?
Also, you'll need a proper ChangeLog entry for both gdb/ChangeLog and
gdb/doc/ChangeLog. Something like:
ChangeLog:
2009-05-28 Richard Ward <richard.j.ward1@googlemail.com>
* python/python-type.c (convert_field): New attribute "base_class".
doc/ChangeLog:
2009-05-28 Richard Ward <richard.j.ward1@googlemail.com>
* gdb.texinfo (Types In Python): Describe "base_class".
Tom, any chance this could go in?
Thanks,
--
Paul Pluzhnikov
next prev parent reply other threads:[~2009-07-01 21:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-01 20:38 Paul Pluzhnikov
2009-07-01 20:52 ` Richard Ward
2009-07-01 21:05 ` Paul Pluzhnikov [this message]
2009-07-01 22:25 ` Richard Ward
2009-07-06 19:20 ` Tom Tromey
2009-07-02 17:20 ` Tom Tromey
2009-07-02 17:29 ` Paul Pluzhnikov
2009-07-02 18:50 ` Richard Ward
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ac60eac0907011405r6013eb17q4afd0d98c740bb5a@mail.gmail.com \
--to=ppluzhnikov@google.com \
--cc=archer@sourceware.org \
--cc=richard.j.ward1@googlemail.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).