From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19006 invoked by alias); 7 Jul 2009 20:41:33 -0000 Mailing-List: contact archer-help@sourceware.org; run by ezmlm Sender: Precedence: bulk List-Post: List-Help: List-Subscribe: List-Id: Received: (qmail 18978 invoked by uid 22791); 7 Jul 2009 20:41:32 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org MIME-Version: 1.0 In-Reply-To: <8ac60eac0907071250h4bbd5219p31e5506bd997cd21@mail.gmail.com> References: <20090707180121.D6ECE76BC0@localhost> <8ac60eac0907071250h4bbd5219p31e5506bd997cd21@mail.gmail.com> Date: Tue, 07 Jul 2009 20:41:00 -0000 Message-ID: <8ac60eac0907071341m71bff75by3b7c958e86bbcd39@mail.gmail.com> Subject: Re: [patch] fix for crash in python pretty-printer From: Paul Pluzhnikov To: Tom Tromey Cc: gdb-patches@sourceware.org, archer@sourceware.org Content-Type: multipart/mixed; boundary=001636427251307b66046e23a52d X-System-Of-Record: true X-SW-Source: 2009-q3/txt/msg00028.txt.bz2 --001636427251307b66046e23a52d Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-length: 484 On Tue, Jul 7, 2009 at 12:50 PM, Paul Pluzhnikov wrote: > Committed to the mainline. It turns out I didn't follow what happens when value_struct_elt() raises error correctly: when it does, res_val will be left as NULL, and that will trigger gdb_assert in my previous patch. Here is a fix. Sorry for the noise :-( -- Paul Pluzhnikov 2009-07-07 Paul Pluzhnikov * python/python-value.c (valpy_getitem): Remove incorrect assert. --001636427251307b66046e23a52d Content-Type: text/plain; charset=US-ASCII; name="gdb-pretty-printer-crash-20090707-2.txt" Content-Disposition: attachment; filename="gdb-pretty-printer-crash-20090707-2.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_fwv349ax0 Content-length: 928 SW5kZXg6IHB5dGhvbi9weXRob24tdmFsdWUuYwo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09ClJDUyBmaWxlOiAvY3ZzL3NyYy9zcmMvZ2RiL3B5dGhvbi9weXRo b24tdmFsdWUuYyx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS4yMgpkaWZmIC11 IC1wIC11IC1yMS4yMiBweXRob24tdmFsdWUuYwotLS0gcHl0aG9uL3B5dGhv bi12YWx1ZS5jCTcgSnVsIDIwMDkgMTk6MzY6MDkgLTAwMDAJMS4yMgorKysg cHl0aG9uL3B5dGhvbi12YWx1ZS5jCTcgSnVsIDIwMDkgMjA6MzI6MjcgLTAw MDAKQEAgLTI5NCwxNyArMjk0LDExIEBAIHZhbHB5X2dldGl0ZW0gKFB5T2Jq ZWN0ICpzZWxmLCBQeU9iamVjdCAKIAl9CiAgICAgfQogCi0gIGlmIChyZXNf dmFsID09IE5VTEwpCi0gICAgewotICAgICAgZ2RiX2Fzc2VydCAoZmllbGQg PT0gTlVMTCk7Ci0gICAgICByZXR1cm4gTlVMTDsKLSAgICB9Ci0KICAgaWYg KGZpZWxkKQogICAgIHhmcmVlIChmaWVsZCk7CiAgIEdEQl9QWV9IQU5ETEVf RVhDRVBUSU9OIChleGNlcHQpOwogCi0gIHJldHVybiB2YWx1ZV90b192YWx1 ZV9vYmplY3QgKHJlc192YWwpOworICByZXR1cm4gcmVzX3ZhbCA/IHZhbHVl X3RvX3ZhbHVlX29iamVjdCAocmVzX3ZhbCkgOiBOVUxMOwogfQogCiBzdGF0 aWMgaW50Cg== --001636427251307b66046e23a52d--