From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9171 invoked by alias); 6 Jan 2010 05:10:44 -0000 Mailing-List: contact archer-help@sourceware.org; run by ezmlm Sender: Precedence: bulk List-Post: List-Help: List-Subscribe: List-Id: Received: (qmail 9160 invoked by uid 22791); 6 Jan 2010 05:10:42 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org MIME-Version: 1.0 Reply-To: matt@mmmccormick.com In-Reply-To: <4B4351CD.5060804@redhat.com> References: <1262192902-11770-1-git-send-email-matt@mmmccormick.com> <1262193413-14509-1-git-send-email-matt@mmmccormick.com> <4B4351CD.5060804@redhat.com> Date: Wed, 06 Jan 2010 05:10:00 -0000 Message-ID: Subject: Re: [PATCH] [python] Add gdb.value_history_count() From: "Matthew McCormick (thewtex)" To: Phil Muldoon Cc: archer@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2010-q1/txt/msg00002.txt.bz2 Thanks for your suggestions. On Tue, Jan 5, 2010 at 8:50 AM, Phil Muldoon wrote: > On 12/30/2009 05:16 PM, Matt McCormick wrote: > > Looks good. =A0As this is Tom's branch he will have to note whether it > can be checked in or not. =A0Some small nits: > > > >> gdb/doc/ChangeLog >> >> 2009-30-12 =A0Matt McCormick =A0 >> >> =A0 =A0 =A0 =A0 * doc/gdb.texinfo (Basic Python): Document gdb.value_his= tory_count. > > > As there is a ChangeLog in the doc/ directory, the paths should be > relative to the ChangeLog. =A0So in this case, the doc/ prefix is not > necessary. > Logical. > >> gdb/testsuite/ChangeLog >> >> 2009-30-12 =A0Matt McCormick =A0 >> >> =A0 =A0 =A0 =A0 * testsuite/gdb.python/py-value.exp (test_value_history_= count): Test >> =A0 =A0 =A0 gdb.value_history_count. > > > Same here with testsuite/. > >> +@findex gdb.value_history_count >> +@defun value_history_count >> +Return an int corresponding to the number of entries in the value histo= ry >> +(@pxref{Value History}). >> +@end defun > > > Missing period at the end of that sentence. > >> >> +/* This returns the number of entries in the value history. =A0*/ >> + >> +int get_value_history_count(); >> + > > Need a space before the '('. > > And git diff --check reports a rogue whitespace ;) > > git diff --check > gdb/testsuite/gdb.python/py-value.exp:277: trailing whitespace. > Git + extra whitespace =3D bull + red flag. > Cheers! > > Phil > Thanks, Phil. Will post an update.