From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26007 invoked by alias); 8 Feb 2010 17:30:12 -0000 Mailing-List: contact archer-help@sourceware.org; run by ezmlm Sender: Precedence: bulk List-Post: List-Help: List-Subscribe: List-Id: Received: (qmail 25993 invoked by uid 22791); 8 Feb 2010 17:30:10 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org From: Tom Tromey To: Sami Wagiaalla Cc: Project Archer Subject: Re: [rfc] patch for pr8880 References: <4B703D65.302@redhat.com> Reply-To: Tom Tromey Date: Mon, 08 Feb 2010 17:30:00 -0000 In-Reply-To: <4B703D65.302@redhat.com> (Sami Wagiaalla's message of "Mon, 08 Feb 2010 11:35:49 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2010-q1/txt/msg00073.txt.bz2 >>>>> "Sami" == Sami Wagiaalla writes: Sami> This was a long chase but an easy fix. Sami> Thoughts ? Lots of formatting nits. Also I have a few more substantive comments. Sami> +struct value * Sami> +value_at_value (struct value *value) Sami> +{ Sami> + return value_at(TYPE_TARGET_TYPE (value_type(value)), Sami> + value_as_address(value)); Why not just use value_ind? Sami> @@ -2104,6 +2111,9 @@ value_struct_elt (struct value **argp, struct value **args, Modifying value_struct_elt seems dangerous. This is called from many places in the code, including some which don't expect ADL to be used -- e.g., Java, Ada. Can this be done by the caller somehow instead? Or perhaps some refactoring is needed. Also, ADL should only be done for unqualified names. It isn't clear to me that this change satisfies that requirement. Tom