From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: archer@sourceware.org
Subject: Re: [next-over-throw2] exception_resume_breakpoint comments
Date: Fri, 30 Apr 2010 16:08:00 -0000 [thread overview]
Message-ID: <m37hno3ovc.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20100429164722.GA5666@host0.dyn.jankratochvil.net> (Jan Kratochvil's message of "Thu, 29 Apr 2010 18:47:22 +0200")
>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
Jan> - does not use TP at all.
Thanks, I fixed this.
It does need to use TP to make the exception-resume breakpoint
thread-specific.
Jan> Then clear_thread_inferior_resources now clears
Jan> tp->step_resume_breakpoint. To make
Jan> tp->exception_resume_breakpoint on par with existing tp->
Jan> step_resume_breakpoint IMO clear_thread_inferior_resources should
Jan> clear even tp->exception_resume_breakpoint.
I did this too.
Jan> Unrelated bug is that both these breakpoints should be set as
Jan> thread-specific.
I think the bp_exception breakpoint is already thread-specific, see
breakpoint.c:set_longjmp_breakpoint. When we clone the exception master
breakpoint we also set its thread.
The `TP' part of the new patch fixes the breakpoint we set to resume the
exception.
Jan> Another unrelated bug is that on a thread exit thread-specific
Jan> breakpoints are not deleted (one may ask if they should be deleted,
Jan> though).
I'm not going to touch this in the general case. Maybe it is worth a
bug report though.
Here's what I plan to commit. I'm going to run it through the tester as
well, just for a little safety.
Tom
diff --git a/gdb/infrun.c b/gdb/infrun.c
index 3546cf1..40a1211 100644
--- a/gdb/infrun.c
+++ b/gdb/infrun.c
@@ -4946,6 +4946,7 @@ insert_exception_resume_breakpoint (struct thread_info *tp,
bp = set_momentary_breakpoint_at_pc (get_frame_arch (frame),
handler, bp_exception_resume);
+ bp->thread = tp->num;
inferior_thread ()->exception_resume_breakpoint = bp;
}
}
diff --git a/gdb/thread.c b/gdb/thread.c
index 3c52ae4..eb0ef8f 100644
--- a/gdb/thread.c
+++ b/gdb/thread.c
@@ -113,6 +113,12 @@ clear_thread_inferior_resources (struct thread_info *tp)
tp->step_resume_breakpoint = NULL;
}
+ if (tp->exception_resume_breakpoint)
+ {
+ tp->exception_resume_breakpoint->disposition = disp_del_at_next_stop;
+ tp->exception_resume_breakpoint = NULL;
+ }
+
bpstat_clear (&tp->stop_bpstat);
discard_all_intermediate_continuations_thread (tp);
next prev parent reply other threads:[~2010-04-30 16:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-29 16:47 Jan Kratochvil
2010-04-30 16:08 ` Tom Tromey [this message]
2010-05-04 19:46 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m37hno3ovc.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=archer@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).