From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26415 invoked by alias); 7 Jul 2009 20:54:48 -0000 Mailing-List: contact archer-help@sourceware.org; run by ezmlm Sender: Precedence: bulk List-Post: List-Help: List-Subscribe: List-Id: Received: (qmail 26396 invoked by uid 22791); 7 Jul 2009 20:54:47 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org To: Paul Pluzhnikov Cc: gdb-patches@sourceware.org, archer@sourceware.org Subject: Re: [patch] fix for crash in python pretty-printer References: <20090707180121.D6ECE76BC0@localhost> <8ac60eac0907071250h4bbd5219p31e5506bd997cd21@mail.gmail.com> <8ac60eac0907071341m71bff75by3b7c958e86bbcd39@mail.gmail.com> From: Tom Tromey Reply-To: Tom Tromey Date: Tue, 07 Jul 2009 20:54:00 -0000 In-Reply-To: <8ac60eac0907071341m71bff75by3b7c958e86bbcd39@mail.gmail.com> (Paul Pluzhnikov's message of "Tue\, 7 Jul 2009 13\:41\:21 -0700") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2009-q3/txt/msg00029.txt.bz2 >>>>> "Paul" == Paul Pluzhnikov writes: Paul> It turns out I didn't follow what happens when value_struct_elt() raises Paul> error correctly: when it does, res_val will be left as NULL, and that will Paul> trigger gdb_assert in my previous patch. I missed that too. Paul> Here is a fix. Sorry for the noise :-( No big deal. This is ok if you haven't committed it already. Paul> if (field) Paul> xfree (field); Jim Meyering has been going around removing these redundant 'if's. This is something I'm *sure* coccinelle can do :-) BTW, I neglected to mention upthread -- Taras has got dehydra and treehydra working for C. So, you could probably write a TRY_CATCH checker in javascript without too much trouble. Tom