From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4960 invoked by alias); 30 Oct 2009 22:18:59 -0000 Mailing-List: contact archer-help@sourceware.org; run by ezmlm Sender: Precedence: bulk List-Post: List-Help: List-Subscribe: List-Id: Received: (qmail 4950 invoked by uid 22791); 30 Oct 2009 22:18:58 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org From: Tom Tromey To: Phil Muldoon Cc: Project Archer Subject: Re: [patch] Fix python/10805 References: <4ADDBEFF.4080805@redhat.com> Reply-To: Tom Tromey Date: Fri, 30 Oct 2009 22:18:00 -0000 In-Reply-To: <4ADDBEFF.4080805@redhat.com> (Phil Muldoon's message of "Tue, 20 Oct 2009 14:45:35 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2009-q4/txt/msg00032.txt.bz2 >>>>> "Phil" == Phil Muldoon writes: Phil> This patch fixes python/10805. When fields were being constructed, the Phil> convert_fields function was not checking if the type was a class Phil> before determining if it was a base class. Added a check to gate this Phil> behaviour. Looks good, thanks. Phil> Additionally, I started a testsuite for Python types. This suite only Phil> tests for this regression, but it can be expanded later, in separate Phil> efforts. Awesome. The is_base_class thing isn't upstream. It would be good to submit all this sometime. Tom