From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23086 invoked by alias); 27 Mar 2009 17:34:40 -0000 Mailing-List: contact archer-help@sourceware.org; run by ezmlm Sender: Precedence: bulk List-Post: List-Help: List-Subscribe: List-Id: Received: (qmail 23075 invoked by uid 22791); 27 Mar 2009 17:34:36 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org To: Phil Muldoon Cc: Project Archer Subject: Re: [python][rfc] Attempt to print the base class if a there is no Python pretty-printer for a derived class. References: <49CD0730.8070000@redhat.com> From: Tom Tromey Reply-To: Tom Tromey Date: Fri, 27 Mar 2009 17:34:00 -0000 In-Reply-To: <49CD0730.8070000@redhat.com> (Phil Muldoon's message of "Fri\, 27 Mar 2009 17\:04\:48 +0000") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2009-q1/txt/msg00423.txt.bz2 >>>>> "Phil" == Phil Muldoon writes: Looking pretty good :) Phil> + /* Attempt to run the Python pretty-printers on the base class of Phil> + the derived class. */ The second line here needs more indentation. "the" should line up with "Attempt". Also you need an extra space after the period. Silly nit-picking... :) Phil> + if (!options->raw) Phil> + if (n_baseclasses > 0) Phil> + { Phil> + Declare baseclass and result here, not at the top of the function. Phil> /* First, print out baseclasses such that we don't print Phil> duplicates of virtual baseclasses. */ Does this logic continue to work properly if one of the virtual baseclasses has a pretty-printer? Please write a couple test cases for this functionality. thanks, Tom