From: Tom Tromey <tromey@redhat.com>
To: Jonas Maebe <jonas.maebe@elis.ugent.be>
Cc: archer@sourceware.org
Subject: Re: Fixes for Mac OS X/x86 building/running
Date: Thu, 12 Mar 2009 23:25:00 -0000 [thread overview]
Message-ID: <m3hc1ytjff.fsf@fleche.redhat.com> (raw)
In-Reply-To: <m3tz5yv0e6.fsf@fleche.redhat.com> (Tom Tromey's message of "Thu\, 12 Mar 2009 16\:31\:29 -0600")
>>>>> "Tom" == Tom Tromey <tromey@redhat.com> writes:
Tom> I suspect you must have added the NULL in the wrong spot
[...]
I checked in this patch on the archer-tromey-delayed-symfile branch.
It ought to fix this bug. I also noticed another instance of this
problem, so I fixed it as well.
If you have the archer branch checked out, you can merge this over.
The commit itself is 1018589cd4646267c3dfc2225d1227f25a85f644, but
there's a merge after it on the branch since I forgot to pull
first... sigh.
Maybe it is time to submit the delayed symfile patch upstream.
I'm having trouble thinking of a reason why not.
Tom
2009-03-12 Jonas Maebe <jonas.maebe@elis.ugent.be>
Tom Tromey <tromey@redhat.com>
* somread.c (som_sym_fns): Add sym_read_psymbols entry.
* machoread.c (macho_sym_fns): Add sym_read_psymbols entry.
diff --git a/gdb/machoread.c b/gdb/machoread.c
index d8d3bd2..248fae2 100644
--- a/gdb/machoread.c
+++ b/gdb/machoread.c
@@ -681,6 +681,7 @@ static struct sym_fns macho_sym_fns = {
macho_new_init, /* sym_new_init: init anything gbl to entire symtab */
macho_symfile_init, /* sym_init: read initial info, setup for sym_read() */
macho_symfile_read, /* sym_read: read a symbol file into symtab */
+ NULL, /* sym_read_psymbols */
macho_symfile_finish, /* sym_finish: finished with file, cleanup */
macho_symfile_offsets, /* sym_offsets: xlate external to internal form */
NULL /* next: pointer to next struct sym_fns */
diff --git a/gdb/somread.c b/gdb/somread.c
index 36a2b28..4d5bda9 100644
--- a/gdb/somread.c
+++ b/gdb/somread.c
@@ -435,6 +435,7 @@ static struct sym_fns som_sym_fns =
som_new_init, /* sym_new_init: init anything gbl to entire symtab */
som_symfile_init, /* sym_init: read initial info, setup for sym_read() */
som_symfile_read, /* sym_read: read a symbol file into symtab */
+ NULL, /* sym_read_psymbols */
som_symfile_finish, /* sym_finish: finished with file, cleanup */
som_symfile_offsets, /* sym_offsets: Translate ext. to int. relocation */
default_symfile_segments, /* sym_segments: Get segment information from
next prev parent reply other threads:[~2009-03-12 23:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-11 19:41 Jonas Maebe
2009-03-12 18:30 ` Jonas Maebe
2009-03-12 18:41 ` Joel Brobecker
2009-03-12 19:28 ` Jonas Maebe
2009-03-12 20:56 ` Tom Tromey
2009-03-12 21:45 ` Jonas Maebe
2009-03-12 22:19 ` [Archer] " Joel Brobecker
2009-03-12 22:33 ` Tom Tromey
2009-03-12 23:07 ` Jonas Maebe
2009-03-12 23:25 ` Tom Tromey [this message]
2009-03-12 22:40 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3hc1ytjff.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=archer@sourceware.org \
--cc=jonas.maebe@elis.ugent.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).