From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15958 invoked by alias); 12 Mar 2009 23:25:33 -0000 Mailing-List: contact archer-help@sourceware.org; run by ezmlm Sender: Precedence: bulk List-Post: List-Help: List-Subscribe: List-Id: Received: (qmail 15888 invoked by uid 22791); 12 Mar 2009 23:25:32 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org To: Jonas Maebe Cc: archer@sourceware.org Subject: Re: Fixes for Mac OS X/x86 building/running References: <26B42B2B-EBF1-48CB-9B10-1678C8FA8154@elis.ugent.be> From: Tom Tromey Reply-To: Tom Tromey Date: Thu, 12 Mar 2009 23:25:00 -0000 In-Reply-To: (Tom Tromey's message of "Thu\, 12 Mar 2009 16\:31\:29 -0600") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2009-q1/txt/msg00378.txt.bz2 >>>>> "Tom" == Tom Tromey writes: Tom> I suspect you must have added the NULL in the wrong spot [...] I checked in this patch on the archer-tromey-delayed-symfile branch. It ought to fix this bug. I also noticed another instance of this problem, so I fixed it as well. If you have the archer branch checked out, you can merge this over. The commit itself is 1018589cd4646267c3dfc2225d1227f25a85f644, but there's a merge after it on the branch since I forgot to pull first... sigh. Maybe it is time to submit the delayed symfile patch upstream. I'm having trouble thinking of a reason why not. Tom 2009-03-12 Jonas Maebe Tom Tromey * somread.c (som_sym_fns): Add sym_read_psymbols entry. * machoread.c (macho_sym_fns): Add sym_read_psymbols entry. diff --git a/gdb/machoread.c b/gdb/machoread.c index d8d3bd2..248fae2 100644 --- a/gdb/machoread.c +++ b/gdb/machoread.c @@ -681,6 +681,7 @@ static struct sym_fns macho_sym_fns = { macho_new_init, /* sym_new_init: init anything gbl to entire symtab */ macho_symfile_init, /* sym_init: read initial info, setup for sym_read() */ macho_symfile_read, /* sym_read: read a symbol file into symtab */ + NULL, /* sym_read_psymbols */ macho_symfile_finish, /* sym_finish: finished with file, cleanup */ macho_symfile_offsets, /* sym_offsets: xlate external to internal form */ NULL /* next: pointer to next struct sym_fns */ diff --git a/gdb/somread.c b/gdb/somread.c index 36a2b28..4d5bda9 100644 --- a/gdb/somread.c +++ b/gdb/somread.c @@ -435,6 +435,7 @@ static struct sym_fns som_sym_fns = som_new_init, /* sym_new_init: init anything gbl to entire symtab */ som_symfile_init, /* sym_init: read initial info, setup for sym_read() */ som_symfile_read, /* sym_read: read a symbol file into symtab */ + NULL, /* sym_read_psymbols */ som_symfile_finish, /* sym_finish: finished with file, cleanup */ som_symfile_offsets, /* sym_offsets: Translate ext. to int. relocation */ default_symfile_segments, /* sym_segments: Get segment information from