From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2343 invoked by alias); 21 Sep 2009 21:52:46 -0000 Mailing-List: contact archer-help@sourceware.org; run by ezmlm Sender: Precedence: bulk List-Post: List-Help: List-Subscribe: List-Id: Received: (qmail 2331 invoked by uid 22791); 21 Sep 2009 21:52:45 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org From: Tom Tromey To: Oguz Kayral Cc: archer@sourceware.org Subject: Re: [RFC][1/5] Changes to the current branch References: <36a35d480908230834n73393daduc92857e82aa2f234@mail.gmail.com> Reply-To: Tom Tromey Date: Mon, 21 Sep 2009 21:52:00 -0000 In-Reply-To: <36a35d480908230834n73393daduc92857e82aa2f234@mail.gmail.com> (Oguz Kayral's message of "Sun, 23 Aug 2009 18:34:44 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2009-q3/txt/msg00239.txt.bz2 Oguz> diff --git a/gdb/python/python-breakpoint.c b/gdb/python/python-breakpoint.c Oguz> -struct breakpoint_object Oguz> -{ Oguz> - PyObject_HEAD Oguz> - Oguz> - /* The breakpoint number according to gdb. */ Oguz> - int number; Oguz> - Oguz> - /* The gdb breakpoint object, or NULL if the breakpoint has been Oguz> - deleted. */ Oguz> - struct breakpoint *bp; Oguz> -}; It seems to me that this type could still be private to the breakpoint code. I think it is generally preferable to do this and use accessor functions. Oguz> +static void Oguz> +python_on_normal_stop (struct bpstats *bs, int print_frame) Oguz> +{ [...] Oguz> + state = PyGILState_Ensure (); We use cleanups for acquiring the GIL now. Oguz> +static void Oguz> +python_thread_exit (struct thread_info *tp, int ignore) Oguz> +{ [...] Oguz> + long long int *exit_code; You can't use long long; just use LONGEST instead. Oguz> + { "stop_eventregistry", thpy_get_stop_eventregistry, NULL, "Stop Oguz> event registry object of the thread.", NULL }, I'm not so sure about the names ending in "registry". "stop_event" seems just as clear to me. Tom