From: Tom Tromey <tromey@redhat.com>
To: Richard Ward <richard.j.ward1@googlemail.com>
Cc: archer@sourceware.org
Subject: Re: Patch to add rtti_type member to gdb.Value
Date: Fri, 25 Sep 2009 20:43:00 -0000 [thread overview]
Message-ID: <m3my4iwyam.fsf@fleche.redhat.com> (raw)
In-Reply-To: <4ABD179F.6050006@googlemail.com> (Richard Ward's message of "Fri, 25 Sep 2009 20:18:55 +0100")
>>>>> "Richard" == Richard Ward <richard.j.ward1@googlemail.com> writes:
Richard> I'll look at the other points later when I have time, but In this case
Richard> if Py_None is used it will be incremented twice before being handed
Richard> back to the caller.
Yeah -- once for the store to obj->type, and once for the caller.
The caller needs a new reference, always.
For obj->type, this lets us call Py_DECREF without checking whether
obj->type is None.
Tom
next prev parent reply other threads:[~2009-09-25 20:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-23 18:37 Richard Ward
2009-09-25 19:03 ` Tom Tromey
2009-09-25 19:19 ` Richard Ward
2009-09-25 20:43 ` Tom Tromey [this message]
2009-09-28 9:55 Richard Ward
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3my4iwyam.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=archer@sourceware.org \
--cc=richard.j.ward1@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).