From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11498 invoked by alias); 7 Jul 2009 18:23:32 -0000 Mailing-List: contact archer-help@sourceware.org; run by ezmlm Sender: Precedence: bulk List-Post: List-Help: List-Subscribe: List-Id: Received: (qmail 11479 invoked by uid 22791); 7 Jul 2009 18:23:31 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org To: ppluzhnikov@google.com (Paul Pluzhnikov) Cc: gdb-patches@sourceware.org, archer@sourceware.org Subject: Re: [patch] fix for crash in python pretty-printer References: <20090707180121.D6ECE76BC0@localhost> From: Tom Tromey Reply-To: Tom Tromey Date: Tue, 07 Jul 2009 18:23:00 -0000 In-Reply-To: <20090707180121.D6ECE76BC0@localhost> (Paul Pluzhnikov's message of "Tue\, 7 Jul 2009 11\:01\:21 -0700 \(PDT\)") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2009-q3/txt/msg00026.txt.bz2 >>>>> "Paul" == Paul Pluzhnikov writes: Paul> Attached is a fix (applies both to mainline and archer-tromey-python). Paul> Tested on Linux/x86_64 with no regressions. This is ok. Thanks. Paul> P.S. Is there an "easy" way to find such mis-uses of TRY_CATCH? Paul> This one took me 2 hours to find :-( Not that I know of :( You could try coccinelle, I suppose. I've run it for other purposes on gdb, though with mixed results. Tom