From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3687 invoked by alias); 19 Feb 2010 23:23:22 -0000 Mailing-List: contact archer-help@sourceware.org; run by ezmlm Sender: Precedence: bulk List-Post: List-Help: List-Subscribe: List-Id: Received: (qmail 3674 invoked by uid 22791); 19 Feb 2010 23:23:21 -0000 X-SWARE-Spam-Status: No, hits=-6.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org From: Tom Tromey To: Sami Wagiaalla Cc: Project Archer Subject: Re: [rfc] patch for pr8880 References: <4B703D65.302@redhat.com> <4B71B645.2050806@redhat.com> <4B7D9890.1070607@redhat.com> Reply-To: Tom Tromey Date: Fri, 19 Feb 2010 23:23:00 -0000 In-Reply-To: <4B7D9890.1070607@redhat.com> (Sami Wagiaalla's message of "Thu, 18 Feb 2010 14:44:16 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2010-q1/txt/msg00081.txt.bz2 >>>>> "Sami" == Sami Wagiaalla writes: Sami> Is it correct to assume then that qualified names should be treated Sami> through evaluation of OP_SCOPE and is not effected by this patch - Sami> baring lexer/parser bugs. Especially since the patch is now restricted Sami> to user defined operators. Yes, I think that is a reasonable goal. It is mostly true now, except that "::name" is not emitted as OP_SCOPE. I think it probably ought to be. Sami> +value_user_defined_adl_op (struct value **args, int nargs, char *operator) The new functions should be static. They need intro comments, as well. On trunk, you'll want to make 'operator' const; I don't know if that little cleanup has made it to expr-cumulative yet. Sami> + arg_types = (struct type **)alloca (nargs * (sizeof (struct type *))); Missing a space before alloca. I think this looks good; check it in with those little changes. Once Keith's big physname series goes in, I think we should push all the remaining expr-cumulative stuff upstream, then shut down the branch and do small fixes like this directly on trunk. For bigger fixes we can still make a branch. I'll handle whatever stuff I've pushed on the branch. Tom