From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <archer-return-1761-listarch-archer=sourceware.org@sourceware.org>
Received: (qmail 15105 invoked by alias); 17 Nov 2009 20:51:00 -0000
Mailing-List: contact archer-help@sourceware.org; run by ezmlm
Sender: <archer@sourceware.org>
Precedence: bulk
List-Post: <mailto:archer@sourceware.org>
List-Help: <mailto:archer-help@sourceware.org>
List-Subscribe: <mailto:archer-subscribe@sourceware.org>
List-Id: <archer.sourceware.org>
Received: (qmail 15096 invoked by uid 22791); 17 Nov 2009 20:50:59 -0000
X-SWARE-Spam-Status: No, hits=-2.5 required=5.0
	tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS
X-Spam-Check-By: sourceware.org
From: Tom Tromey <tromey@redhat.com>
To: Sami Wagiaalla <swagiaal@redhat.com>
Cc: Project Archer <archer@sourceware.org>
Subject: Re: [RFC] Koenig lookup patch 3
References: <49BABABE.9080606@redhat.com> <m3d4clrs4z.fsf@fleche.redhat.com>
	<49F87751.8050405@redhat.com> <m3iqkndmck.fsf@fleche.redhat.com>
	<4A969900.6040100@redhat.com> <m3zl9lorki.fsf@fleche.redhat.com>
	<4AD6340F.9070108@redhat.com> <4AD63BA4.4070309@redhat.com>
	<m3tyy0tmcd.fsf@fleche.redhat.com> <4AEF2E3C.30601@redhat.com>
	<m3my2vh4zj.fsf@fleche.redhat.com> <4B02C888.5000409@redhat.com>
Reply-To: Tom Tromey <tromey@redhat.com>
Date: Tue, 17 Nov 2009 20:51:00 -0000
In-Reply-To: <4B02C888.5000409@redhat.com> (Sami Wagiaalla's message of "Tue,
	17 Nov 2009 11:00:08 -0500")
Message-ID: <m3ocn0ri4z.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-SW-Source: 2009-q4/txt/msg00063.txt.bz2

>>>>> "Sami" == Sami Wagiaalla <swagiaal@redhat.com> writes:

Sami> +    if (sym == NULL && !lookup_minimal_symbol (tmp, NULL, NULL) && parse_language->la_language == language_cplus)

This wraps.

More importantly, order the conditions so that the slowest one comes last.

Otherwise it seems reasonable to me.

Tom