public inbox for archer@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Noam Yorav-Raphael <noamraph@gmail.com>
Cc: archer <archer@sourceware.org>
Subject: Re: python: a patch for getting target thread id from a thread object
Date: Tue, 29 Sep 2009 18:05:00 -0000	[thread overview]
Message-ID: <m3ske5bp9j.fsf@fleche.redhat.com> (raw)
In-Reply-To: <b348a0850909290257i6d4ba4aue264a625f656d45f@mail.gmail.com> (Noam Yorav-Raphael's message of "Tue, 29 Sep 2009 12:57:02 +0300")

>>>>> "Noam" == Noam Yorav-Raphael <noamraph@gmail.com> writes:

Noam> Here's a simple patch which adds a method for getting the target
Noam> thread id of a Thread object.

I think the idea is fine.

BTW do you have copyright papers on file?  I don't remember, and I can't
easily look... if not we have to do that before we can accept
non-trivial patches.

Noam> +  { "get_target_id", thpy_get_target_id, METH_NOARGS,
Noam> +    "get_target_id () -> str\n\
Noam> +Return the target ID of the thread." },

We went through and remove the "get_" prefixes everywhere a while back.
Also, I think this should be an attribute (see thread_object_getset), as
that is more consistent with our current API decisions.

Finally, this patch needs an update to doc/gdb.texinfo.

thanks,
Tom

      reply	other threads:[~2009-09-29 18:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-29  9:57 Noam Yorav-Raphael
2009-09-29 18:05 ` Tom Tromey [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3ske5bp9j.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=archer@sourceware.org \
    --cc=noamraph@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).