From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <archer-return-1683-listarch-archer=sourceware.org@sourceware.org>
Received: (qmail 13132 invoked by alias); 25 Sep 2009 18:37:16 -0000
Mailing-List: contact archer-help@sourceware.org; run by ezmlm
Sender: <archer@sourceware.org>
Precedence: bulk
List-Post: <mailto:archer@sourceware.org>
List-Help: <mailto:archer-help@sourceware.org>
List-Subscribe: <mailto:archer-subscribe@sourceware.org>
List-Id: <archer.sourceware.org>
Received: (qmail 13120 invoked by uid 22791); 25 Sep 2009 18:37:15 -0000
X-SWARE-Spam-Status: No, hits=-2.4 required=5.0
	tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS
X-Spam-Check-By: sourceware.org
From: Tom Tromey <tromey@redhat.com>
To: Richard Ward <richard.j.ward1@googlemail.com>
Cc: archer@sourceware.org
Subject: Re: [RFC][2/5] Event and event registry
References: <36a35d480908230835s661fdbc2r3844a95c212a8fb@mail.gmail.com>
	<m3eiq0x8sa.fsf@fleche.redhat.com> <4ABAAF04.4020608@googlemail.com>
Reply-To: Tom Tromey <tromey@redhat.com>
Date: Fri, 25 Sep 2009 18:37:00 -0000
In-Reply-To: <4ABAAF04.4020608@googlemail.com> (Richard Ward's message of
	"Thu, 24 Sep 2009 00:28:04 +0100")
Message-ID: <m3skeayipd.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-SW-Source: 2009-q3/txt/msg00249.txt.bz2

>>>>> "Richard" == Richard Ward <richard.j.ward1@googlemail.com> writes:

Tom> I always forget whether the list APIs incref themselves, or not.

Richard> As a general rule, The list/dict/tupe functions do their own
Richard> incrementing (so the Py_INCREF above is not needed).

Thanks.

Richard> FWIW there seem to be a fair few places in gdb where Py_INCREF is used
Richard> over-zealously. Sometimes this is just extra increments to python's
Richard> None, True and False values, which I suppose won't cause any leaks,
Richard> but there are a few places that will.

If you know of ones offhand, let me know and I will fix them.

Tom