From: Tom Tromey <tromey@redhat.com>
To: Phil Muldoon <pmuldoon@redhat.com>
Cc: Project Archer <archer@sourceware.org>
Subject: Re: [patch] Do not allow invalid subscript operations on GDB values
Date: Wed, 16 Sep 2009 16:48:00 -0000 [thread overview]
Message-ID: <m3skemsun9.fsf@fleche.redhat.com> (raw)
In-Reply-To: <4AB0DD7B.4090400@redhat.com> (Phil Muldoon's message of "Wed, 16 Sep 2009 13:43:39 +0100")
>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:
Phil> Thanks for looking at the patch. In an additional test I added, the
Phil> reference fails without coerce_ref. So ... I added the coerce_ref back
Phil> into the code. The only way I could think to test this is to add C++
Phil> bits to the testcase. But I'm not totally sure that I am testing your
Phil> original concern. So before I commit, can you give it one more once
Phil> over? The patch is pretty much the same other than the coerce_ref
Phil> call, and the addition of the C++ test. Thanks!
Looks good, thanks!
Tom
prev parent reply other threads:[~2009-09-16 16:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-15 9:58 Phil Muldoon
2009-09-15 20:43 ` Tom Tromey
2009-09-16 12:43 ` Phil Muldoon
2009-09-16 16:48 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3skemsun9.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=archer@sourceware.org \
--cc=pmuldoon@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).