public inbox for archer@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: archer@sourceware.org
Subject: Re: Improved linker-debugger interface
Date: Wed, 25 May 2011 18:21:00 -0000	[thread overview]
Message-ID: <m3tyciwsj8.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20110525153649.GB3149@redhat.com> (Gary Benson's message of "Wed, 25 May 2011 16:36:50 +0100")

Gary> I've attached a patch for glibc that implements its side of the
Gary> interface, designed to apply after the SystemTap support that was
Gary> added for F15, so if what I've written doesn't make sense then maybe
Gary> at least the code will!

Gary> Does this all seem ok?

It makes sense as far as I understand it.  I don't know glibc very well.
I'd suggest asking Andreas Schwab for a review.

Gary> +void
Gary> +_dl_debug_state_extended (Lmid_t ns, struct r_debug *r)
Gary> +{
Gary> +  if (r->r_state == RT_CONSISTENT)
Gary> +    {
Gary> +      LIBC_PROBE (r_debug_mod_complete, 2, ns, r);
Gary> +    }
Gary> +  else
Gary> +    {
Gary> +      LIBC_PROBE (r_debug_mod_starting, 2, ns, r);
Gary> +    }

Will 'ns' give gdb enough information to do its work in the dlmopen
case?  Or will we want gdb to have access to some other thing?  I am
wondering Lmid_t is just some internal-to-glibc cookie, where gdb will
actually want a pointer to some ld.so data structure.  I don't actually
know anything about this though.

Tom

  reply	other threads:[~2011-05-25 18:21 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-25 15:37 Gary Benson
2011-05-25 18:21 ` Tom Tromey [this message]
2011-05-26 17:02   ` Gary Benson
2011-05-26 17:25     ` Tom Tromey
2011-05-26 17:37 ` Paul Pluzhnikov
2011-05-26 17:47   ` Tom Tromey
2011-05-26 21:07     ` Tom Tromey
2011-05-31 16:25   ` Gary Benson
2011-05-31 19:46     ` Tom Tromey
2011-05-31 20:41       ` Paul Pluzhnikov
2011-05-31 20:46         ` Tom Tromey
2011-05-31 21:05           ` Paul Pluzhnikov
2011-06-02 23:56             ` Tom Tromey
2011-06-07 16:58 ` Jan Kratochvil
2011-06-08 10:56   ` Gary Benson
2011-06-01  1:24 Frank Ch. Eigler
2011-06-02 23:56 ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3tyciwsj8.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=archer@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).