From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16573 invoked by alias); 25 May 2011 18:21:22 -0000 Mailing-List: contact archer-help@sourceware.org; run by ezmlm Sender: Precedence: bulk List-Post: List-Help: List-Subscribe: List-Id: Received: (qmail 16561 invoked by uid 22791); 25 May 2011 18:21:21 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org From: Tom Tromey To: archer@sourceware.org Subject: Re: Improved linker-debugger interface References: <20110525153649.GB3149@redhat.com> Date: Wed, 25 May 2011 18:21:00 -0000 In-Reply-To: <20110525153649.GB3149@redhat.com> (Gary Benson's message of "Wed, 25 May 2011 16:36:50 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2011-q2/txt/msg00001.txt.bz2 Gary> I've attached a patch for glibc that implements its side of the Gary> interface, designed to apply after the SystemTap support that was Gary> added for F15, so if what I've written doesn't make sense then maybe Gary> at least the code will! Gary> Does this all seem ok? It makes sense as far as I understand it. I don't know glibc very well. I'd suggest asking Andreas Schwab for a review. Gary> +void Gary> +_dl_debug_state_extended (Lmid_t ns, struct r_debug *r) Gary> +{ Gary> + if (r->r_state == RT_CONSISTENT) Gary> + { Gary> + LIBC_PROBE (r_debug_mod_complete, 2, ns, r); Gary> + } Gary> + else Gary> + { Gary> + LIBC_PROBE (r_debug_mod_starting, 2, ns, r); Gary> + } Will 'ns' give gdb enough information to do its work in the dlmopen case? Or will we want gdb to have access to some other thing? I am wondering Lmid_t is just some internal-to-glibc cookie, where gdb will actually want a pointer to some ld.so data structure. I don't actually know anything about this though. Tom