From: Tom Tromey <tromey@redhat.com>
To: Daniel Jacobowitz <drow@false.org>
Cc: archer@sourceware.org
Subject: Re: Initial psymtab replacement results
Date: Wed, 16 Dec 2009 19:31:00 -0000 [thread overview]
Message-ID: <m3tyvqk96u.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20091216181059.GA7619@caradoc.them.org> (Daniel Jacobowitz's message of "Wed, 16 Dec 2009 13:10:59 -0500")
>>>>> "Daniel" == Daniel Jacobowitz <drow@false.org> writes:
Daniel> Did you create the index, then populate the table? Is it quicker to
Daniel> populate the table, and then create the index?
I did both, they are both slow.
Originally I didn't have an index and when I was playing with the SQLite
shell I noticed searches were slow. So, I made an index -- which was
very slow to create in the shell.
Then I thought that maybe making the index before populating the table
would be faster. I made that change to gdb, but it was still quite
slow.
Another idea I have is to make a new column holding a hash code, and not
use an index; or maybe use that for the index (indexing on an integer
column may be faster).
I was experimenting just now, and removing the "CREATE INDEX" and
changing the schema to mark symbols.name as "PRIMARY KEY" made database
creation much faster -- for gdb, down from 60 seconds to 19. I still
think that is too slow though.
Daniel> Frank made a good point about putting host characteristics in the
Daniel> cache key. By careful choice of the types stored, we should be able
Daniel> to create a mapped data structure that is in practice dependent only
Daniel> on endianness and maybe pointer size. WDYT?
Yeah, I may give that a try.
Daniel> I know you've done a lot of work to kill psymtabs. Do we populate
Daniel> psymtabs from the index, or are they pretty much optional now? In
Daniel> other words, can we reclaim and reuse the memory formerly spent on
Daniel> psymtabs?
What I did was introduce a new struct of function pointers, alongside
struct sym_fns. This provides an abstraction that replaces direct uses
of partial symbols. The API "design" is completely ad hoc, based on
what previously existed. So, it is rather weird and large; e.g., it has
a special function just for Ada, because ada-lang.c directly examines
psymtabs.
Then I moved all the uses of partial symbols into a new file, psymtab.c,
and made a new rule: only psymtab.c and the debuginfo readers are
allowed to directly manipulate these data structures.
Finally, I changed dwarf2read.c to have a separate implementation of
these functions, and to use its own indexing data structures.
dwarf2read now decides per-objfile whether to use partial symbols or the
new code.
I did all this because I did not think it was possible to really create
psymbols from the DWARF indices.
This approach saves a bit of memory when using the index. I don't have
numbers handy but my recollection is that the savings isn't very
dramatic.
I have considered modifying dwarf2read to create "new-style" data
structures when the indices are not available. I haven't implemented
this yet, though, because it is more work and the payoff doesn't seem to
be huge.
The new code could free some memory whenever it reads full symbols for a
CU. I haven't implemented that yet.
Finally, with "-readnow", dwarf2read no longer reads partial symbols or
the indices; it skips directly to just reading everything. I only did
this because it was easy to implement; I actually consider -readnow to
be fairly useless.
Another idea I have is to change the threaded-dwarf branch to read
psymtabs in the background thread. This isn't too terribly hard, now
that psymtabs are fully segregated.
Tom
next prev parent reply other threads:[~2009-12-16 19:31 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-10 21:54 Tom Tromey
2009-12-11 23:10 ` Tom Tromey
2009-12-11 23:59 ` Daniel Jacobowitz
2009-12-14 22:40 ` Tom Tromey
2009-12-14 23:09 ` Daniel Jacobowitz
2009-12-15 23:39 ` Tom Tromey
2009-12-16 3:01 ` Roland McGrath
2009-12-16 18:20 ` Tom Tromey
2009-12-16 18:57 ` Roland McGrath
2009-12-16 19:46 ` Tom Tromey
2009-12-16 19:52 ` Roland McGrath
2009-12-16 18:11 ` Daniel Jacobowitz
2009-12-16 19:31 ` Tom Tromey [this message]
2009-12-23 18:29 ` Tom Tromey
2009-12-23 18:35 ` Daniel Jacobowitz
2009-12-24 17:07 ` Tom Tromey
2010-01-06 23:05 ` Tom Tromey
2009-12-17 16:39 ` Paul Pluzhnikov
2009-12-17 16:53 ` Daniel Jacobowitz
2009-12-17 17:20 ` Paul Pluzhnikov
2009-12-17 18:16 ` Daniel Jacobowitz
2009-12-18 23:58 ` Tom Tromey
2009-12-21 13:54 ` Daniel Jacobowitz
2009-12-21 21:29 ` Tom Tromey
2009-12-15 1:04 ` Roland McGrath
2009-12-15 18:36 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3tyvqk96u.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=archer@sourceware.org \
--cc=drow@false.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).