public inbox for archer@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Jonas Maebe <jonas.maebe@elis.ugent.be>
Cc: archer@sourceware.org
Subject: Re: Fixes for Mac OS X/x86 building/running
Date: Thu, 12 Mar 2009 22:33:00 -0000	[thread overview]
Message-ID: <m3tz5yv0e6.fsf@fleche.redhat.com> (raw)
In-Reply-To: <26B42B2B-EBF1-48CB-9B10-1678C8FA8154@elis.ugent.be> (Jonas Maebe's message of "Thu\, 12 Mar 2009 22\:44\:39 +0100")

>>>>> "Jonas" == Jonas Maebe <jonas.maebe@elis.ugent.be> writes:

Tom> I've appended the corresponding change from elfread.c.
Tom> You probably want something a bit more like this.  The delayed symfile
Tom> stuff only works if you also arrange to create the quick addrmap.

Jonas> Thanks. I've now adjusted the machoread.c code in a similar way, but
Jonas> there's no change in the behaviour. I'll take it to the main gdb
Jonas> mailing list, with a CC to Tristan Gingold.

Just FYI, the machoread.c patch won't apply upstream, because we
haven't submitted the delayed partial symbol reading patch yet.

Tom> Or, you can just set the new field to NULL.  All this means is that
Tom> you won't get lazy loading of debug info.

Jonas> That causes a crash when symfile.c:897 calls this function
Jonas> unconditionally:

I suspect you must have added the NULL in the wrong spot, because that
line is:

  (*objfile->sf->sym_read) (objfile, mainline);

... but the new field is the next field in the struct,
sym_read_psymbols.

Tom

  parent reply	other threads:[~2009-03-12 22:33 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-11 19:41 Jonas Maebe
2009-03-12 18:30 ` Jonas Maebe
2009-03-12 18:41   ` Joel Brobecker
2009-03-12 19:28     ` Jonas Maebe
2009-03-12 20:56 ` Tom Tromey
2009-03-12 21:45   ` Jonas Maebe
2009-03-12 22:19     ` [Archer] " Joel Brobecker
2009-03-12 22:33     ` Tom Tromey [this message]
2009-03-12 23:07       ` Jonas Maebe
2009-03-12 23:25       ` Tom Tromey
2009-03-12 22:40 ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3tz5yv0e6.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=archer@sourceware.org \
    --cc=jonas.maebe@elis.ugent.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).