From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <archer-return-2020-listarch-archer=sourceware.org@sourceware.org>
Received: (qmail 30075 invoked by alias); 2 Jul 2010 20:10:20 -0000
Mailing-List: contact archer-help@sourceware.org; run by ezmlm
Sender: <archer@sourceware.org>
Precedence: bulk
List-Post: <mailto:archer@sourceware.org>
List-Help: <mailto:archer-help@sourceware.org>
List-Subscribe: <mailto:archer-subscribe@sourceware.org>
List-Id: <archer.sourceware.org>
Received: (qmail 30054 invoked by uid 22791); 2 Jul 2010 20:10:17 -0000
X-SWARE-Spam-Status: No, hits=-6.0 required=5.0
	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
From: Tom Tromey <tromey@redhat.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Roland McGrath <roland@redhat.com>, "Frank Ch. Eigler" <fche@redhat.com>,
        archer@sourceware.org
Subject: Re: PATCH? gdb remote.c: readchar() should pop_target() if SERIAL_ERROR?
References: <20100702011302.GA24599@redhat.com>
Date: Fri, 02 Jul 2010 20:10:00 -0000
In-Reply-To: <20100702011302.GA24599@redhat.com> (Oleg Nesterov's message of
	"Fri, 2 Jul 2010 03:13:02 +0200")
Message-ID: <m3vd8xk5lr.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-SW-Source: 2010-q3/txt/msg00003.txt.bz2

>>>>> "Oleg" == Oleg Nesterov <oleg@redhat.com> writes:

Oleg> I was trying to learn how gdb works with gdbserver and hit the bug.
Oleg> The patch below seems to fix the problem for me but I am not sure
Oleg> it is correct, I never looked into the (complex!) gdb sources before.

It seems reasonable to me, too.  However, I don't know this part of gdb
very well.

I suggest re-sending your email to gdb-patches@sourceware.org.  Some of
the maintainers there are very familiar with remote.c and friends.

Tom