From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <archer-return-2039-listarch-archer=sourceware.org@sourceware.org>
Received: (qmail 29923 invoked by alias); 9 Jul 2010 17:48:06 -0000
Mailing-List: contact archer-help@sourceware.org; run by ezmlm
Sender: <archer@sourceware.org>
Precedence: bulk
List-Post: <mailto:archer@sourceware.org>
List-Help: <mailto:archer-help@sourceware.org>
List-Subscribe: <mailto:archer-subscribe@sourceware.org>
List-Id: <archer.sourceware.org>
Received: (qmail 29885 invoked by uid 22791); 9 Jul 2010 17:48:04 -0000
X-SWARE-Spam-Status: No, hits=-6.0 required=5.0
	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
From: Tom Tromey <tromey@redhat.com>
To: Panu Matilainen <pmatilai@redhat.com>
Cc: Roland McGrath <roland@redhat.com>, Project Archer <archer@sourceware.org>
Subject: Re: find-debuginfo.sh change for gdb index
References: <m3vd91tqpl.fsf@fleche.redhat.com>
	<20100629232147.C019548255@magilla.sf.frob.com>
	<m3r5joscvs.fsf@fleche.redhat.com>
	<20100630181436.518364C33C@magilla.sf.frob.com>
	<m31vbos7lc.fsf@fleche.redhat.com> <m3y6dws151.fsf@fleche.redhat.com>
	<20100630204424.3DCE34C33C@magilla.sf.frob.com>
	<m3lj9wrz60.fsf@fleche.redhat.com>
	<20100630221406.254AC4C33E@magilla.sf.frob.com>
	<m339w1lkuu.fsf@fleche.redhat.com>
	<alpine.LFD.2.00.1007051223290.8757@localhost>
	<m38w5ocvcj.fsf@fleche.redhat.com>
	<20100706191407.535874824F@magilla.sf.frob.com>
	<m3k4p66k7l.fsf@fleche.redhat.com>
	<20100708225253.3470A4D6C2@magilla.sf.frob.com>
	<alpine.LFD.2.00.1007090802460.3611@localhost>
Date: Fri, 09 Jul 2010 17:48:00 -0000
In-Reply-To: <alpine.LFD.2.00.1007090802460.3611@localhost> (Panu Matilainen's
	message of "Fri, 9 Jul 2010 08:07:27 +0300 (EEST)")
Message-ID: <m3wrt41r91.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-SW-Source: 2010-q3/txt/msg00022.txt.bz2

>>>>> "Panu" == Panu Matilainen <pmatilai@redhat.com> writes:

>> gdb-add-index "$f" > /dev/null 2>&1

Panu> Sounds good to me. Also if it were an external script that might not
Panu> be there (depending on gdb-version), find-debuginfo.sh can do
[...]

Indeed, the latest patch is just the line you wrote.

I sent the gdb-add-index patch to gdb-patches.  I don't know whether it
will go in (I think historically gdb has avoided installing scripts),
but in any case Jan is going to put it into the gdb RPM.

Tom

--- find-debuginfo.sh.orig	2010-06-29 16:19:42.000000000 -0600
+++ find-debuginfo.sh	2010-07-09 11:35:39.000000000 -0600
@@ -207,6 +207,8 @@
     $strict && exit 2
   fi
 
+  [ -x /usr/bin/gdb-add-index ] && /usr/bin/gdb-add-index "$f" > /dev/null 2>&1
+
   # A binary already copied into /usr/lib/debug doesn't get stripped,
   # just has its file names collected and adjusted.
   case "$dn" in