From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26901 invoked by alias); 27 Mar 2009 17:47:45 -0000 Mailing-List: contact archer-help@sourceware.org; run by ezmlm Sender: Precedence: bulk List-Post: List-Help: List-Subscribe: List-Id: Received: (qmail 26890 invoked by uid 22791); 27 Mar 2009 17:47:44 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org To: Phil Muldoon Cc: Project Archer Subject: Re: [python][rfc] Attempt to print the base class if a there is no Python pretty-printer for a derived class. References: <49CD0730.8070000@redhat.com> <49CD1045.5070301@redhat.com> From: Tom Tromey Reply-To: Tom Tromey Date: Fri, 27 Mar 2009 17:47:00 -0000 In-Reply-To: <49CD1045.5070301@redhat.com> (Phil Muldoon's message of "Fri\, 27 Mar 2009 17\:43\:33 +0000") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2009-q1/txt/msg00427.txt.bz2 >>>>> "Phil" == Phil Muldoon writes: Phil> It works in so much as this is a "do or continue with the old logic"; Phil> the existing Python pretty-printers would handle these if they were Phil> called, no? My understanding of the current code is that if you have a repeated virtual base class, it will only be printed once. So, the test case here would be to have a pretty-printer for the virtual base -- then, make sure that it is only invoked a single time. Phil> I was thinking of a documentation patch in the narrative Phil> regarding printer selection too. But is this just going to be Phil> superfluous to the reader? My first reaction is that we don't need a documentation update for this. It is just a simple extension of the generic logic to a different case of printing -- this change is a technical one, related to the implementation, not really a different use. Tom