inadvertently-removed-from-git: gdb/windows-termcap.c

inadvertently-removed-from-git: gdb/windows-termcap.c

[Jim Meyering]

Matt Rice wrote:
> if you look at cvsweb the file exists,
> http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/windows-termcap.c?cvsroot=src
>
> but it doesn't exist in the gitweb
> http://sourceware.org/git/?p=gdb.git;a=tree;f=gdb;h=f65ecd3e7173a8346ab5993ddced32d48395a64c;hb=HEAD
>
> here is appears that the file was moved outside of cvs somehow
>
> http://sourceware.org/ml/gdb-patches/2009-01/msg00250.html

Summary: win32-termcap.c was renamed to windows-termcap.c,
and windows-termcap.c appears in a CVS checkout, but not in
a git clone.

I investigated and found that the problem lies in how
the cvs-renaming was performed.  Presumably while trying
to preserve its history in the renamed ,v file, this renaming
was handled differently from the others in that same change set.
The renamed-to windows-termcap.c,v file contains all of the history
of the old-named win32-termcap.c,v.  Something about that file
made it so the mirroring process missed it.

For the record, the usual "cp FILE NEW_NAME; cvs rm -f FILE; cvs add NEW_NAME"
works perfectly for cvs-to-git mirror and in git afterward: it can easily
detect the renaming.

Here's the patch I've just pushed:

From 8efc4dcdaf267c9fb24410c62a364782289f7662 Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering@redhat.com>
Date: Wed, 4 Mar 2009 20:05:11 +0100
Subject: [PATCH] gdb/windows-termcap.c: manually add accidentally-omitted file

* git/windows-termcap.c: Due to the way win32-termcap.c was renamed to
windows-termcap.c in CVS, the addition of the latter was not detected
by the cvs-to-git mirroring process.  This change merely adds the
omitted file to the GIT repository.  For reference, the addition
was supposed to have been via this commit:
3f7d5964e85c, 2009-01-12 "Fix linking with --enable-targets=all:"
---
 gdb/windows-termcap.c |   65 +++++++++++++++++++++++++++++++++++++++++++++++++
 1 files changed, 65 insertions(+), 0 deletions(-)
 create mode 100644 gdb/windows-termcap.c

diff --git a/gdb/windows-termcap.c b/gdb/windows-termcap.c
new file mode 100644
index 0000000..9034c17
--- /dev/null
+++ b/gdb/windows-termcap.c
@@ -0,0 +1,65 @@
+/* Win32 termcap emulation.
+
+   Copyright (C) 2005, 2006, 2007, 2008, 2009 Free Software Foundation, Inc.
+
+   Contributed by CodeSourcery, LLC.
+
+   This file is part of GDB.
+
+   This program is free software; you can redistribute it and/or modify
+   it under the terms of the GNU General Public License as published by
+   the Free Software Foundation; either version 3 of the License, or
+   (at your option) any later version.
+
+   This program is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+   GNU General Public License for more details.
+
+   You should have received a copy of the GNU General Public License
+   along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
+
+#include <stdlib.h>
+
+/* Each of the files below is a minimal implementation of the standard
+   termcap function with the same name, suitable for use in a Windows
+   console window.  */
+
+int
+tgetent (char *buffer, char *termtype)
+{
+  return -1;
+}
+
+int
+tgetnum (char *name)
+{
+  return -1;
+}
+
+int
+tgetflag (char *name)
+{
+  return -1;
+}
+
+char *
+tgetstr (char *name, char **area)
+{
+  return NULL;
+}
+
+int
+tputs (char *string, int nlines, int (*outfun) ())
+{
+  while (*string)
+    outfun (*string++);
+
+  return 0;
+}
+
+char *
+tgoto (const char *cap, int col, int row)
+{
+  return NULL;
+}
--
1.6.2.rc1.285.gc5f54

Re: inadvertently-removed-from-git: gdb/windows-termcap.c

[Tom Tromey]

Jim> For the record, the usual "cp FILE NEW_NAME; cvs rm -f FILE; cvs
Jim> add NEW_NAME" works perfectly for cvs-to-git mirror and in git
Jim> afterward: it can easily detect the renaming.

CVS users, unfortunately, have a history of trying to work around CVS'
limitations by hacking on the ,v files.  Blah.

Jim> Here's the patch I've just pushed:

Thanks for clearing this up.
I will pull it over to the archer repository now, if nobody else has
done so already.

Tom

Re: inadvertently-removed-from-git: gdb/windows-termcap.c

[Tom Tromey]

>>>>> "Jim" == Jim Meyering <jim@meyering.net> writes:

Jim> Summary: win32-termcap.c was renamed to windows-termcap.c,
Jim> and windows-termcap.c appears in a CVS checkout, but not in
Jim> a git clone.

Jim> Here's the patch I've just pushed:
Jim> From 8efc4dcdaf267c9fb24410c62a364782289f7662 Mon Sep 17 00:00:00 2001

I still don't see this in the git repository.
Did it not go in?  Or not on the 'master' branch?

Tom

Re: inadvertently-removed-from-git: gdb/windows-termcap.c

[Jim Meyering]

Tom Tromey wrote:
>>>>>> "Jim" == Jim Meyering <jim@meyering.net> writes:
> Jim> Summary: win32-termcap.c was renamed to windows-termcap.c,
> Jim> and windows-termcap.c appears in a CVS checkout, but not in
> Jim> a git clone.
>
> Jim> Here's the patch I've just pushed:
> Jim> From 8efc4dcdaf267c9fb24410c62a364782289f7662 Mon Sep 17 00:00:00 2001
>
> I still don't see this in the git repository.
> Did it not go in?  Or not on the 'master' branch?

Oh!
Could have sworn I pushed it, but obviously didn't.
It's there now:

  http://sources.redhat.com/git/gitweb.cgi?p=gdb.git;a=commitdiff;h=d1ea5a6d98

Thanks for the prod ;-)