From: manfred-h@t-online.de (Manfred Hollstein)
To: ian@cygnus.com, bfd@cygnus.com
Subject: PATCH for bfd in gas-990404
Date: Sat, 10 Apr 1999 08:52:00 -0000 [thread overview]
Message-ID: <14095.21193.644654.472600@saturn.hollstein.net> (raw)
Hi there.
On Tue, 23 February 1999, 17:20:23, manfred@s-direktnet.de wrote:
> This small patch fixes a bug I observed while running gdb-4.17
> on a mips-sgi-irix5.3 system. Since the debuggee's debug info
> was larger than the system's virtual memory was able to provide,
> the "goto error_return" in bfd/elf32-mips.c:_bfd_mips_elf_read_ecoff_info
> got executed, which in turn tries to cleanup allocated memory.
> Unfortunately, it's simply checking probably unitialized
> memory to decide whether it should.
>
Nobody commented on this behaviour so far. The bug is still there.
Later,
manfred
1999-04-10 Manfred Hollstein <mhollstein@cygnus.com>
* elf32-mips.c (_bfd_mips_elf_read_ecoff_info): Ensure only actually
allocated members will be free'ed at error_return.
diff -rup -x CVS -x RCS -x *.o -x *.info* -x *.html* -x *.elc -x *.dvi -x *.orig -x *~ -x version.el gas-990404.orig/bfd/elf32-mips.c gas-990404/bfd/elf32-mips.c
--- gas-990404.orig/bfd/elf32-mips.c Sun Apr 4 11:17:12 1999
+++ gas-990404/bfd/elf32-mips.c Sat Apr 10 14:40:39 1999
@@ -3055,6 +3055,20 @@ _bfd_mips_elf_read_ecoff_info (abfd, sec
swap = get_elf_backend_data (abfd)->elf_backend_ecoff_debug_swap;
+ /* Ensure only actually allocated members will be free'ed at
+ error_return. */
+ debug->line = NULL;
+ debug->external_dnr = NULL;
+ debug->external_pdr = NULL;
+ debug->external_sym = NULL;
+ debug->external_opt = NULL;
+ debug->external_aux = NULL;
+ debug->ss = NULL;
+ debug->ssext = NULL;
+ debug->external_fdr = NULL;
+ debug->external_rfd = NULL;
+ debug->external_ext = NULL;
+
ext_hdr = (char *) bfd_malloc ((size_t) swap->external_hdr_size);
if (ext_hdr == NULL && swap->external_hdr_size != 0)
goto error_return;
reply other threads:[~1999-04-10 8:52 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14095.21193.644654.472600@saturn.hollstein.net \
--to=manfred-h@t-online.de \
--cc=bfd@cygnus.com \
--cc=ian@cygnus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).