public inbox for bfd@sourceware.org
 help / color / mirror / Atom feed
From: Jeffrey A Law <law@hurl.cygnus.com>
To: Ian Lance Taylor <ian@cygnus.com>
Cc: hjl@lucon.org, bfd@cygnus.com
Subject: Re: A patch for elf.c
Date: Wed, 09 Dec 1998 10:03:00 -0000	[thread overview]
Message-ID: <5560.913226553@hurl.cygnus.com> (raw)
In-Reply-To: <199812091735.MAA29788@subrogation.cygnus.com>

  In message < 199812091735.MAA29788@subrogation.cygnus.com >you write:
  >    > introduced with a change to the function a few months ago.  The fix is
  >    > to avoid introducing bugs; clearing memory is just treating the
  >    > symptom.
  > 
  >    To me, clearing memory is the super set of setting one field to
  >    zero. I am a better safe than sorry person. I have no time
  >    to second guess if there is another field I should clear.
  > 
  > I know you don't mean this, but to me ``I have no time to second
  > guess'' sounds like ``I have no time to figure out how the code works,
  > or what the right patch is.''  In a long running project like GNU,
  > anybody who wants to make changes has to take the time to understand
  > them.  We're not quickly hacking stuff together for the big demo next
  > Wednesday; we're writing code that should, ideally, survive for twenty
  > years.
  > 
  > I also agree with Roland's point.
IMHO, clearing a block of memory to fix a problem without understanding
precisely why clearing the block fixes the problem is just papering over a
bug.

Once one understands precisely why clearing one or more memory locations is
fixing a bug, once can decide if clearing one or more fields or a whole
structure/array is the best solution.

I believe gdb operates under a similar guidelines.


jeff

  reply	other threads:[~1998-12-09 10:03 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <Pine.LNX.3.96.981208082500.26204A-100000@beezer.med.miami.edu>
1998-12-08  9:57 ` H.J. Lu
1998-12-08 10:28   ` Christopher C Chimelis
1998-12-08 11:26   ` Ian Lance Taylor
1998-12-08 11:34     ` Christopher C Chimelis
1998-12-09  7:42     ` H.J. Lu
1998-12-09  8:04       ` Roland McGrath
1998-12-09  9:35       ` Ian Lance Taylor
1998-12-09 10:03         ` Jeffrey A Law [this message]
1998-12-09 16:27         ` Stan Shebs

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5560.913226553@hurl.cygnus.com \
    --to=law@hurl.cygnus.com \
    --cc=bfd@cygnus.com \
    --cc=hjl@lucon.org \
    --cc=ian@cygnus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).