public inbox for bfd@sourceware.org
 help / color / mirror / Atom feed
From: hjl@lucon.org (H.J. Lu)
To: rth@cygnus.com
Cc: manfred@s-direktnet.de, bfd@cygnus.com, gas2@cygnus.com,
	Manfred.Hollstein@ks.sel.alcatel.de
Subject: Re: Bugs in recent snapshots on Solaris
Date: Fri, 20 Mar 1998 08:19:00 -0000	[thread overview]
Message-ID: <m0yG4Vu-00058JC@ocean.lucon.org> (raw)
In-Reply-To: <19980320023241.39647@dot.cygnus.com>

> 
> > -      /* If this symbol is not defined in a regular file, and we are
> > -	 not generating a shared library, then set the symbol to this
> > -	 location in the .plt.  This is required to make function
> > -	 pointers compare as equal between the normal executable and
> > -	 the shared library.  */
> > -      if (! info->shared
> > -	  && (h->elf_link_hash_flags & ELF_LINK_HASH_DEF_REGULAR) == 0)
> > -	{
> > -	  h->root.u.def.section = s;
> > -	  h->root.u.def.value = s->_raw_size;
> > -	}
> > +      /* Set the symbol to this location in the .plt.  This is
> > +	 required to make function pointers compare as equal between
> > +	 the normal executable and the shared library.  */
> > +      h->root.u.def.section = s;
> > +      h->root.u.def.value = s->_raw_size;
> 
> This was the offending bit.  The other part is righteous.
> Somewhere I got a bit overeager.
> 

Is that fixed now in the snapshot? I need to make a new binutils for
Linux to get this and an x86 bug fixed.

Thanks.


-- 
H.J. Lu (hjl@gnu.org)

      reply	other threads:[~1998-03-20  8:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
1998-03-13  0:47 Manfred Hollstein
1998-03-13  1:21 ` Manfred Hollstein
1998-03-13 16:09   ` Ken Raeburn
1998-03-20  2:30   ` Richard Henderson
1998-03-20  8:19     ` H.J. Lu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m0yG4Vu-00058JC@ocean.lucon.org \
    --to=hjl@lucon.org \
    --cc=Manfred.Hollstein@ks.sel.alcatel.de \
    --cc=bfd@cygnus.com \
    --cc=gas2@cygnus.com \
    --cc=manfred@s-direktnet.de \
    --cc=rth@cygnus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).