public inbox for binutils-cvs@sourceware.org
help / color / mirror / Atom feed
From: Alan Modra <amodra@sourceware.org>
To: bfd-cvs@sourceware.org
Subject: [binutils-gdb] PR29337, readelf CU/TU mixup in .gdb_index
Date: Thu, 21 Jul 2022 05:32:59 +0000 (GMT)	[thread overview]
Message-ID: <20220721053259.B1CF3385735D@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=e82295b23d0e52b0dadffb8c0d0b99462cd20fa8

commit e82295b23d0e52b0dadffb8c0d0b99462cd20fa8
Author: Alan Modra <amodra@gmail.com>
Date:   Thu Jul 21 14:54:54 2022 +0930

    PR29337, readelf CU/TU mixup in .gdb_index
    
    Commit 244e19c79111 changed a number of variables in display_gdb_index
    to count entries rather than words.
    
            PR 29337
            * dwarf.c (display_gdb_index): Correct use of cu_list_elements.

Diff:
---
 binutils/dwarf.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/binutils/dwarf.c b/binutils/dwarf.c
index 99fb3566994..7d0a9ffefea 100644
--- a/binutils/dwarf.c
+++ b/binutils/dwarf.c
@@ -10671,9 +10671,9 @@ display_gdb_index (struct dwarf_section *section,
 	      kind = GDB_INDEX_SYMBOL_KIND_VALUE (cu);
 	      cu = GDB_INDEX_CU_VALUE (cu);
 	      /* Convert to TU number if it's for a type unit.  */
-	      if (cu >= cu_list_elements / 2)
+	      if (cu >= cu_list_elements)
 		printf ("%cT%lu", num_cus > 1 ? '\t' : ' ',
-			(unsigned long) (cu - cu_list_elements / 2));
+			(unsigned long) (cu - cu_list_elements));
 	      else
 		printf ("%c%lu", num_cus > 1 ? '\t' : ' ', (unsigned long) cu);


                 reply	other threads:[~2022-07-21  5:32 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220721053259.B1CF3385735D@sourceware.org \
    --to=amodra@sourceware.org \
    --cc=bfd-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).