public inbox for binutils-cvs@sourceware.org
help / color / mirror / Atom feed
From: Vladimir Mezentsev <vmezents@sourceware.org>
To: bfd-cvs@sourceware.org, gdb-cvs@sourceware.org
Subject: [binutils-gdb/binutils-2_39-branch] gprofng: fix bug 29352 - Fix the message Hexadecimal number > 0xffffffff non-portable
Date: Mon, 25 Jul 2022 21:54:05 +0000 (GMT)	[thread overview]
Message-ID: <20220725215405.1C5A3385842B@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=0d8e5bba736d9846043cbe1ecc7c0e374022b57a

commit 0d8e5bba736d9846043cbe1ecc7c0e374022b57a
Author: Ruud van der Pas <ruud.vanderpas@oracle.com>
Date:   Fri Jul 22 06:27:41 2022 -0700

    gprofng: fix bug 29352 - Fix the message Hexadecimal number > 0xffffffff non-portable
    
    gprofng/Changelog:
    2022-07-22  Ruud van der Pas  <ruud.vanderpas@oracle.com>
    
            PR gprofng/29352
            * gp-display-html/gp-display-html.in: the hex subroutine from
            the bigint module is now used.

Diff:
---
 gprofng/gp-display-html/gp-display-html.in | 26 +++++++++++++-------------
 1 file changed, 13 insertions(+), 13 deletions(-)

diff --git a/gprofng/gp-display-html/gp-display-html.in b/gprofng/gp-display-html/gp-display-html.in
index 9b207b99aa8..8297be62b2f 100644
--- a/gprofng/gp-display-html/gp-display-html.in
+++ b/gprofng/gp-display-html/gp-display-html.in
@@ -1246,8 +1246,8 @@ sub calculate_target_hex_address
   
   $length_of_string = length ($instruction_offset); 
   $first_char       = lcfirst (substr ($instruction_offset,0,1));
-  $d1               = hex ($instruction_offset);
-  $d2               = hex ($mask);
+  $d1               = bigint::hex ($instruction_offset);
+  $d2               = bigint::hex ($mask);
 #          if ($first_char eq "f")
   if (($first_char =~ /[89a-f]/) and ($length_of_string == $number_of_fields))
     {
@@ -1258,12 +1258,12 @@ sub calculate_target_hex_address
 # XOR the decimal representation and add 1 to the result.
 #------------------------------------------------------------------------------
       $result = ($d1 ^ $d2) + 1;
-      $dec_branch_target = hex ($instruction_address) - $result;
+      $dec_branch_target = bigint::hex ($instruction_address) - $result;
     }
   else
     {
       $result = $d1;
-      $dec_branch_target = hex ($instruction_address) + $result;
+      $dec_branch_target = bigint::hex ($instruction_address) + $result;
     }
 #------------------------------------------------------------------------------
 # Convert to hexadecimal.
@@ -1765,7 +1765,7 @@ sub check_loadobjects_are_elf
           gp_message ("debug", $subr_name, "extracted name_path = $name_path name = $name");
 #              $error_extracting_information = $TRUE;
           $executable_name  = $name;
-          my $result_VA = hex ($vaddr) - hex ($foffset);
+          my $result_VA = bigint::hex ($vaddr) - bigint::hex ($foffset);
           my $hex_VA = sprintf ("0x%016x", $result_VA);
           $va_executable_in_hex = $hex_VA;
           gp_message ("debug", $subr_name, "set executable_name  = $executable_name");
@@ -2728,7 +2728,7 @@ sub determine_base_va_address
       $base_va_address = "0x0";
     }
    
-  my $decimal_address = hex ($base_va_address);
+  my $decimal_address = bigint::hex ($base_va_address);
   gp_message ("debugXL", $subr_name, "return base_va_address = $base_va_address (decimal: $decimal_address)");
 
   return ($base_va_address);
@@ -3602,7 +3602,7 @@ sub extract_info_from_map_xml
 #------------------------------------------------------------------------------
           $full_path_exec       = $name_path;
           $executable_name      = $name;
-          my $result_VA         = hex ($vaddr) - hex ($foffset);
+          my $result_VA         = bigint::hex ($vaddr) - bigint::hex ($foffset);
           $va_executable_in_hex = sprintf ("0x%016x", $result_VA);
 
 ##          $ARCHIVES_MAP_NAME  = $name;
@@ -4364,7 +4364,7 @@ sub function_info
               my ($segment,$offset);
               $segment = $1;
               $offset = $2;
-              $address_decimal = hex ($offset); # decimal
+              $address_decimal = bigint::hex ($offset); # decimal
               $full_address_field = '@'.$segment.":".$offset; # e.g. @2:0x0003f280
               $order[$index_val]{"addressobj"} = $address_decimal;
               $order[$index_val]{"addressobjtext"} = $full_address_field;
@@ -5481,7 +5481,7 @@ sub generate_dis_html
               $hot_line      = $1;
               $metric_values = $2;
               $src_line      = $3;
-              $dec_instr_address = hex ($4);
+              $dec_instr_address = bigint::hex ($4);
               $instruction   = $5;
               $operands      = $6;
 
@@ -5556,7 +5556,7 @@ sub generate_dis_html
               $hot_line      = $1;
               $metric_values = $2;
               $src_line      = $3;
-              $dec_instr_address = hex ($4);
+              $dec_instr_address = bigint::hex ($4);
               $instruction   = $5;
               $operands      = $6;
 
@@ -5711,7 +5711,7 @@ sub generate_dis_html
                 {
                   $branch_address = $extended_branch_target{$hex_instr_address};
 
-                  $dec_branch_address = hex ($branch_address);
+                  $dec_branch_address = bigint::hex ($branch_address);
 
                   if ( ($dec_branch_address >= $dec_instruction_start) and
                        ($dec_branch_address <= $dec_instruction_end) )
@@ -7707,7 +7707,7 @@ sub get_function_info
 #------------------------------------------------------------------------------
 # Convert to a base 10 number
 #------------------------------------------------------------------------------
-              $address_decimal = hex ($offset); # decimal
+              $address_decimal = bigint::hex ($offset); # decimal
 #------------------------------------------------------------------------------
 # Construct the address field.  Note that we use the hex address here.
 #------------------------------------------------------------------------------
@@ -11139,7 +11139,7 @@ sub process_function_files
 ###############################################################################
           gp_message ("debugXL", $subr_name, "before function_info[$routine_index]{addressobj} = $function_info[$routine_index]{'addressobj'}");
 
-          $function_info[$routine_index]{"addressobj"} += hex (
+          $function_info[$routine_index]{"addressobj"} += bigint::hex (
                                                 determine_base_va_address (
                                                   $executable_name, 
                                                   $base_va_executable,


                 reply	other threads:[~2022-07-25 21:54 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220725215405.1C5A3385842B@sourceware.org \
    --to=vmezents@sourceware.org \
    --cc=bfd-cvs@sourceware.org \
    --cc=gdb-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).