public inbox for binutils-cvs@sourceware.org
help / color / mirror / Atom feed
From: Rainer Orth <ro@sourceware.org>
To: bfd-cvs@sourceware.org
Subject: [binutils-gdb] ld: Extend ac_default_ld_warn_rwx_segments to all SPARC targets [PR29411]
Date: Fri, 29 Jul 2022 07:07:01 +0000 (GMT)	[thread overview]
Message-ID: <20220729070701.C9EF5385780E@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=b80b72c06c29d257b60b4002bd9d6c40dec94ec9

commit b80b72c06c29d257b60b4002bd9d6c40dec94ec9
Author: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
Date:   Fri Jul 29 09:06:40 2022 +0200

    ld: Extend ac_default_ld_warn_rwx_segments to all SPARC targets [PR29411]
    
    As discussed in PR ld/29411, the ld warning
    
            [...] has a LOAD segment with RWX permissions
    
    needs to be disabled on all SPARC targets, not just Solaris/SPARC: the
    .plt section is required to be RWX by the 32-bit SPARC ELF psABI and the
    64-bit SPARC Compliance Definition 2.4.1.  Given that ld only supports
    SPARC ELF targets, this patch implements this.
    
    Tested on sparc64-unknown-linux-gnu and sparc-sun-solaris2.11.
    
    2022-07-28  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
    
            ld:
            PR ld/29411
            * configure.tgt (ac_default_ld_warn_rwx_segments): Extend to all
            sparc targets.  Expand comment.

Diff:
---
 ld/ChangeLog     | 6 ++++++
 ld/configure.tgt | 6 +++---
 2 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/ld/ChangeLog b/ld/ChangeLog
index ac1365a16c6..30fc1937d06 100644
--- a/ld/ChangeLog
+++ b/ld/ChangeLog
@@ -1,3 +1,9 @@
+2022-07-29  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
+
+	PR ld/29411
+	* configure.tgt (ac_default_ld_warn_rwx_segments): Extend to all
+	sparc targets.  Expand comment.
+
 2022-07-26  Nick Clifton  <nickc@redhat.com>
 
 	PR 29411
diff --git a/ld/configure.tgt b/ld/configure.tgt
index 1a3c7df0ae8..2bae9099b6a 100644
--- a/ld/configure.tgt
+++ b/ld/configure.tgt
@@ -49,13 +49,13 @@ if test "${ac_default_ld_warn_rwx_segments}" = unset; then
   case "${targ}" in
       # The CRIS default linker script yields just one segment
       # as intended, so a rwx segment warning is not helpful.
-      # The HPPA's PLT section uses a constructed trampoline
+      # The HPPA's and SPARC's PLT sections use a constructed trampoline
       # hence it needs to have a RWX segment.
       # Many MIPS targets use executable segments.
     cris-*-* | crisv32-*-* | \
     hppa*-*-* | \
-    sparc*-*-solaris2* | \
-    mips*-*-*)
+    mips*-*-* | \
+    sparc*-*-*)
       ac_default_ld_warn_rwx_segments=0
       ;;
     *)


                 reply	other threads:[~2022-07-29  7:07 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220729070701.C9EF5385780E@sourceware.org \
    --to=ro@sourceware.org \
    --cc=bfd-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).