public inbox for binutils-cvs@sourceware.org help / color / mirror / Atom feed
From: Alan Modra <amodra@sourceware.org> To: bfd-cvs@sourceware.org Subject: [binutils-gdb] PR16005, avr linker crash on a particular instruction sequence with --relax Date: Fri, 29 Jul 2022 07:56:53 +0000 (GMT) [thread overview] Message-ID: <20220729075653.B6ADC3857C6E@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=b875e9c93df9f30efb34a75b9379490c03ec4d4b commit b875e9c93df9f30efb34a75b9379490c03ec4d4b Author: Alan Modra <amodra@gmail.com> Date: Fri Jul 29 16:52:52 2022 +0930 PR16005, avr linker crash on a particular instruction sequence with --relax It's possible for relax_delete_bytes to be called with section contents NULL, as demonstrated by the testcase in this PR. PR 16005 * elf32-avr.c (elf32_avr_relax_delete_bytes): Get section contents if not already available. Diff: --- bfd/elf32-avr.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/bfd/elf32-avr.c b/bfd/elf32-avr.c index 48591b8c904..3a1d238e707 100644 --- a/bfd/elf32-avr.c +++ b/bfd/elf32-avr.c @@ -1927,6 +1927,9 @@ elf32_avr_relax_delete_bytes (bfd *abfd, symtab_hdr = &elf_tdata (abfd)->symtab_hdr; sec_shndx = _bfd_elf_section_from_bfd_section (abfd, sec); contents = elf_section_data (sec)->this_hdr.contents; + if (contents == NULL + && !bfd_malloc_and_get_section (abfd, sec, &contents)) + return false; relax_info = get_avr_relax_info (sec); toaddr = sec->size;
reply other threads:[~2022-07-29 7:56 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220729075653.B6ADC3857C6E@sourceware.org \ --to=amodra@sourceware.org \ --cc=bfd-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).