[binutils-gdb] PR16005, avr linker crash on a particular instruction sequence with --relax

[binutils-gdb] PR16005, avr linker crash on a particular instruction sequence with --relax

[Alan Modra]

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=b875e9c93df9f30efb34a75b9379490c03ec4d4b

commit b875e9c93df9f30efb34a75b9379490c03ec4d4b
Author: Alan Modra <amodra@gmail.com>
Date:   Fri Jul 29 16:52:52 2022 +0930

    PR16005, avr linker crash on a particular instruction sequence with --relax
    
    It's possible for relax_delete_bytes to be called with section
    contents NULL, as demonstrated by the testcase in this PR.
    
            PR 16005
            * elf32-avr.c (elf32_avr_relax_delete_bytes): Get section contents
            if not already available.

Diff:
---
 bfd/elf32-avr.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/bfd/elf32-avr.c b/bfd/elf32-avr.c
index 48591b8c904..3a1d238e707 100644
--- a/bfd/elf32-avr.c
+++ b/bfd/elf32-avr.c
@@ -1927,6 +1927,9 @@ elf32_avr_relax_delete_bytes (bfd *abfd,
   symtab_hdr = &elf_tdata (abfd)->symtab_hdr;
   sec_shndx = _bfd_elf_section_from_bfd_section (abfd, sec);
   contents = elf_section_data (sec)->this_hdr.contents;
+  if (contents == NULL
+      && !bfd_malloc_and_get_section (abfd, sec, &contents))
+    return false;
   relax_info = get_avr_relax_info (sec);
 
   toaddr = sec->size;