public inbox for binutils-cvs@sourceware.org
help / color / mirror / Atom feed
From: Matthew Malcomson <matmal01@sourceware.org>
To: bfd-cvs@sourceware.org
Subject: [binutils-gdb] ld: aarch64: Update test linker scripts relocs.ld and relocs-ilp32.ld
Date: Tue,  2 Aug 2022 11:11:27 +0000 (GMT)	[thread overview]
Message-ID: <20220802111127.3AB77385382C@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=b90e0b2f1b516ea32789ae3877830b518cb8ed60

commit b90e0b2f1b516ea32789ae3877830b518cb8ed60
Author: Matthew Malcomson <hardenedapple@gmail.com>
Date:   Tue Aug 2 12:07:00 2022 +0100

    ld: aarch64: Update test linker scripts relocs.ld and relocs-ilp32.ld
    
    The updates are to ensure that the .data section exists.  This means
    that we always have a data section.  That means that we don't create a
    RWX segment and avoid the corresponding warning.
    
    We get this warning when testing aarch64-none-elf with -mcmodel=tiny.
    N.b. this changes quite a few testcases from fail to pass.

Diff:
---
 ld/testsuite/ld-aarch64/relocs-ilp32.ld | 4 ++++
 ld/testsuite/ld-aarch64/relocs.ld       | 4 ++++
 2 files changed, 8 insertions(+)

diff --git a/ld/testsuite/ld-aarch64/relocs-ilp32.ld b/ld/testsuite/ld-aarch64/relocs-ilp32.ld
index 7174aff236f..4ddba914120 100644
--- a/ld/testsuite/ld-aarch64/relocs-ilp32.ld
+++ b/ld/testsuite/ld-aarch64/relocs-ilp32.ld
@@ -16,4 +16,8 @@ SECTIONS
   . = 0x12340000;
   .far : { *(.far) }
   .ARM.attributes 0 : { *(.ARM.atttributes) }
+  /* Providing a .data section triggers a non-executable segment to be
+     generated, which gives somewhere else for the linker to put the TLS
+     segment without creating a RWX permissioned one. */
+  .data : { *(.data) }
 }
diff --git a/ld/testsuite/ld-aarch64/relocs.ld b/ld/testsuite/ld-aarch64/relocs.ld
index f42176e64d3..77adac8b46e 100644
--- a/ld/testsuite/ld-aarch64/relocs.ld
+++ b/ld/testsuite/ld-aarch64/relocs.ld
@@ -16,4 +16,8 @@ SECTIONS
   . = 0x12340000;
   .far : { *(.far) }
   .ARM.attributes 0 : { *(.ARM.atttributes) }
+  /* Providing a .data section triggers a non-executable segment to be
+     generated, which gives somewhere else for the linker to put the TLS
+     segment without creating a RWX permissioned one. */
+  .data : { *(.data) }
 }


                 reply	other threads:[~2022-08-02 11:11 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220802111127.3AB77385382C@sourceware.org \
    --to=matmal01@sourceware.org \
    --cc=bfd-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).