public inbox for binutils-cvs@sourceware.org
help / color / mirror / Atom feed
From: Jan Beulich <jbeulich@sourceware.org>
To: bfd-cvs@sourceware.org
Subject: [binutils-gdb] gas: fix a testcase broken by new ZSTD support
Date: Fri,  5 Aug 2022 09:52:20 +0000 (GMT)	[thread overview]
Message-ID: <20220805095220.D768C3858C53@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=8005415fe923df328546c844729f11d9ed28e270

commit 8005415fe923df328546c844729f11d9ed28e270
Author: Tsukasa OI <research_trasio@irq.a4lg.com>
Date:   Fri Aug 5 11:52:09 2022 +0200

    gas: fix a testcase broken by new ZSTD support
    
    The commit 1369522f36eece1b37139a81f7f2139ba3915172 ("Recognize the new ELF
    compression type for ZSTD.") added the new ELF compression type but it
    accidentally broke a GAS testcase.  Since testing for the section type
    "2048" (SHF_COMPRESSED) is not going to be portable in the long term, it
    now tests SHF_LINK_ORDER ("128") instead.
    
    Using SHF_LINK_ORDER (with possibly sh_link == 0) is an idea by Jan Beulich.
    
    gas/ChangeLog:
    
            * testsuite/gas/elf/section10.s: Use SHF_LINK_ORDER to test
            mixed numeric and alpha values.
            * testsuite/gas/elf/section10.d: Reflect the change above.

Diff:
---
 gas/testsuite/gas/elf/section10.d | 3 +--
 gas/testsuite/gas/elf/section10.s | 2 +-
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/gas/testsuite/gas/elf/section10.d b/gas/testsuite/gas/elf/section10.d
index d51bd4e36e5..6aa57d42943 100644
--- a/gas/testsuite/gas/elf/section10.d
+++ b/gas/testsuite/gas/elf/section10.d
@@ -13,8 +13,7 @@
 [ 	]*\[.*6000000\]: OS \(.*6000000\)
 [ 	]*\[.*\][ 	]+sec2
 [ 	]*PROGBITS.*
-[ 	]*\[0+00806\]: ALLOC, EXEC, COMPRESSED
-[ 	]*\[<unknown>: 0x[0-9]+\], .*
+[ 	]*\[0+00086\]: ALLOC, EXEC, LINK ORDER
 #...
 [ 	]*\[.*\][ 	]+sec3
 [ 	]*PROGBITS.*
diff --git a/gas/testsuite/gas/elf/section10.s b/gas/testsuite/gas/elf/section10.s
index d52b3458fb1..e617bad609c 100644
--- a/gas/testsuite/gas/elf/section10.s
+++ b/gas/testsuite/gas/elf/section10.s
@@ -3,7 +3,7 @@
 	.word 1
 
 	# Make sure that a numeric value can be mixed with alpha values.
-	.section sec2, "a2048x"
+	.section sec2, "a128x"
 	.word 2
 
 	# Make sure that specifying further arguments to .sections is still supported


                 reply	other threads:[~2022-08-05  9:52 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220805095220.D768C3858C53@sourceware.org \
    --to=jbeulich@sourceware.org \
    --cc=bfd-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).