public inbox for binutils-cvs@sourceware.org
help / color / mirror / Atom feed
From: Alan Modra <amodra@sourceware.org>
To: bfd-cvs@sourceware.org
Subject: [binutils-gdb] asan: segfault in coff_write_auxent_fname
Date: Sat,  6 Aug 2022 09:13:58 +0000 (GMT)	[thread overview]
Message-ID: <20220806091358.E1B68385BAF0@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=431d48ef288983b62df2afb435dc8c6101a34cf8

commit 431d48ef288983b62df2afb435dc8c6101a34cf8
Author: Alan Modra <amodra@gmail.com>
Date:   Sat Aug 6 17:36:32 2022 +0930

    asan: segfault in coff_write_auxent_fname
    
    More fuzzed input file nonsense.
    
            * coffgen.c (coff_write_symbol): Don't call coff_write_auxent_fname
            when extrap is NULL.

Diff:
---
 bfd/coffgen.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/bfd/coffgen.c b/bfd/coffgen.c
index 07b3fb446aa..4d2b82e4a6f 100644
--- a/bfd/coffgen.c
+++ b/bfd/coffgen.c
@@ -1058,7 +1058,8 @@ coff_write_symbol (bfd *abfd,
 	  /* Adjust auxent only if this isn't the filename
 	     auxiliary entry.  */
 	  if (native->u.syment.n_sclass == C_FILE
-	      && (native + j + 1)->u.auxent.x_file.x_ftype)
+	      && (native + j + 1)->u.auxent.x_file.x_ftype
+	      && (native + j + 1)->extrap)
 	    coff_write_auxent_fname (abfd, (char *) (native + j + 1)->extrap,
 				     &(native + j + 1)->u.auxent, strtab, hash);


                 reply	other threads:[~2022-08-06  9:13 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220806091358.E1B68385BAF0@sourceware.org \
    --to=amodra@sourceware.org \
    --cc=bfd-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).