public inbox for binutils-cvs@sourceware.org
help / color / mirror / Atom feed
From: Alan Modra <amodra@sourceware.org>
To: bfd-cvs@sourceware.org
Subject: [binutils-gdb] asan: NULL dereference in som_set_reloc_info
Date: Sat, 13 Aug 2022 06:52:49 +0000 (GMT)	[thread overview]
Message-ID: <20220813065249.E7FEA3857B8D@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=8c68d88cc44ec476125e30835f79865e8eb32358

commit 8c68d88cc44ec476125e30835f79865e8eb32358
Author: Alan Modra <amodra@gmail.com>
Date:   Sat Aug 13 14:05:24 2022 +0930

    asan: NULL dereference in som_set_reloc_info
    
            * som.c (som_set_reloc_info): Ignore non-existent previous
            fixup references.

Diff:
---
 bfd/som.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/bfd/som.c b/bfd/som.c
index d33ad67561a..c22f13b5a4c 100644
--- a/bfd/som.c
+++ b/bfd/som.c
@@ -4978,6 +4978,11 @@ som_set_reloc_info (unsigned char *fixup,
       /* Handle a request for a previous fixup.  */
       if (*fp->format == 'P')
 	{
+	  if (!reloc_queue[fp->D].reloc)
+	    /* The back-reference doesn't exist.  This is a broken
+	       object file, likely fuzzed.  Just ignore the fixup.  */
+	    continue;
+
 	  /* Get pointer to the beginning of the prev fixup, move
 	     the repeated fixup to the head of the queue.  */
 	  fixup = reloc_queue[fp->D].reloc;


                 reply	other threads:[~2022-08-13  6:52 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220813065249.E7FEA3857B8D@sourceware.org \
    --to=amodra@sourceware.org \
    --cc=bfd-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).