From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1062) id 056EC3857C44; Sat, 13 Aug 2022 06:52:55 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 056EC3857C44 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Alan Modra To: bfd-cvs@sourceware.org Subject: [binutils-gdb] ubsan: undefined shift in sign_extend X-Act-Checkin: binutils-gdb X-Git-Author: Alan Modra X-Git-Refname: refs/heads/master X-Git-Oldrev: 8c68d88cc44ec476125e30835f79865e8eb32358 X-Git-Newrev: 9effb9f15f4811a80169801b5d2938961424a7d4 Message-Id: <20220813065255.056EC3857C44@sourceware.org> Date: Sat, 13 Aug 2022 06:52:55 +0000 (GMT) X-BeenThere: binutils-cvs@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Aug 2022 06:52:55 -0000 https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3D9effb9f15f48= 11a80169801b5d2938961424a7d4 commit 9effb9f15f4811a80169801b5d2938961424a7d4 Author: Alan Modra Date: Sat Aug 13 14:07:31 2022 +0930 ubsan: undefined shift in sign_extend =20 * libhppa.h (sign_extend): Avoid undefined behaviour. Diff: --- bfd/libhppa.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bfd/libhppa.h b/bfd/libhppa.h index 1de2d5c943b..ebaffe66abf 100644 --- a/bfd/libhppa.h +++ b/bfd/libhppa.h @@ -162,7 +162,7 @@ enum hppa_reloc_expr_type_alt static inline unsigned ATTRIBUTE_UNUSED sign_extend (unsigned x, unsigned len) { - unsigned signbit =3D (1 << (len - 1)); + unsigned signbit =3D (1u << (len - 1)); unsigned mask =3D (signbit << 1) - 1; return ((x & mask) ^ signbit) - signbit; }