public inbox for binutils-cvs@sourceware.org
help / color / mirror / Atom feed
From: Alan Modra <amodra@sourceware.org>
To: bfd-cvs@sourceware.org
Subject: [binutils-gdb] asan: NULL dereference in spu_elf_object_p
Date: Sat, 13 Aug 2022 06:53:00 +0000 (GMT)	[thread overview]
Message-ID: <20220813065300.16E653857C7C@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=80075150727d653c39e9d037e15c6b87dcef08cd

commit 80075150727d653c39e9d037e15c6b87dcef08cd
Author: Alan Modra <amodra@gmail.com>
Date:   Sat Aug 13 14:09:24 2022 +0930

    asan: NULL dereference in spu_elf_object_p
    
            * elf32-spu.c (spu_elf_object_p): Don't dereference NULL
            shdr->bfd_section.

Diff:
---
 bfd/elf32-spu.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/bfd/elf32-spu.c b/bfd/elf32-spu.c
index dc973fadc6c..1e2002ed879 100644
--- a/bfd/elf32-spu.c
+++ b/bfd/elf32-spu.c
@@ -286,7 +286,8 @@ spu_elf_object_p (bfd *abfd)
 	      {
 		Elf_Internal_Shdr *shdr = elf_elfsections (abfd)[j];
 
-		if (ELF_SECTION_SIZE (shdr, phdr) != 0
+		if (shdr->bfd_section != NULL
+		    && ELF_SECTION_SIZE (shdr, phdr) != 0
 		    && ELF_SECTION_IN_SEGMENT (shdr, phdr))
 		  {
 		    asection *sec = shdr->bfd_section;


                 reply	other threads:[~2022-08-13  6:53 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220813065300.16E653857C7C@sourceware.org \
    --to=amodra@sourceware.org \
    --cc=bfd-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).