From: Aaron Merey <amerey@sourceware.org>
To: bfd-cvs@sourceware.org
Subject: [binutils-gdb] objdump: '-S' should trigger search for separate debuginfo.
Date: Tue, 13 Sep 2022 13:32:11 +0000 (GMT) [thread overview]
Message-ID: <20220913133211.9DC513858D39@sourceware.org> (raw)
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=e9a241e87b42f902d0408704df6bbcd8bf465a46
commit e9a241e87b42f902d0408704df6bbcd8bf465a46
Author: Aaron Merey <amerey@redhat.com>
Date: Mon Sep 12 18:57:38 2022 -0400
objdump: '-S' should trigger search for separate debuginfo.
Add with_source_code to the command line options that trigger
might_need_separate_debug_info and dump_any_debugging. This helps
'objdump -S' download missing files via debuginfod without the need for
specifying extra command line options like '-L'.
Diff:
---
binutils/ChangeLog | 7 +++++++
binutils/objdump.c | 5 +++--
2 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/binutils/ChangeLog b/binutils/ChangeLog
index 3cac2353e3b..41a2f9cb0c7 100644
--- a/binutils/ChangeLog
+++ b/binutils/ChangeLog
@@ -1,3 +1,10 @@
+2022-09-12 Aaron Merey <amerey@redhat.com>
+
+ * objcopy.c (might_need_separate_debug_info): Add with_source_code to
+ the options that cause this function to return true.
+ (main.c): Add with_source_code to the options that enable
+ dump_any_debugging.
+
2022-09-09 Nick Clifton <nickc@redhat.com>
PR 29532
diff --git a/binutils/objdump.c b/binutils/objdump.c
index d34f269b406..6610906f83e 100644
--- a/binutils/objdump.c
+++ b/binutils/objdump.c
@@ -5407,7 +5407,7 @@ might_need_separate_debug_info (bool is_mainfile)
return true;
if (process_links || dump_symtab || dump_debugging
- || dump_dwarf_section_info)
+ || dump_dwarf_section_info || with_source_code)
return true;
return false;
@@ -6114,7 +6114,8 @@ main (int argc, char **argv)
dump_any_debugging = (dump_debugging
|| dump_dwarf_section_info
- || process_links);
+ || process_links
+ || with_source_code);
if (formats_info)
exit_status = display_info ();
reply other threads:[~2022-09-13 13:32 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220913133211.9DC513858D39@sourceware.org \
--to=amerey@sourceware.org \
--cc=bfd-cvs@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).