public inbox for binutils-cvs@sourceware.org
 help / color / mirror / Atom feed
From: Alan Modra <amodra@sourceware.org>
To: bfd-cvs@sourceware.org
Subject: [binutils-gdb] ubsan: arm-dis.c index out of bounds
Date: Wed, 14 Sep 2022 00:50:26 +0000 (GMT)	[thread overview]
Message-ID: <20220914005026.463EE395562E@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=f15ba945a49b75c23f8133f3be170a681bb050de

commit f15ba945a49b75c23f8133f3be170a681bb050de
Author: Alan Modra <amodra@gmail.com>
Date:   Mon Sep 12 18:09:24 2022 +0930

    ubsan: arm-dis.c index out of bounds
    
    We are way off in the weeds with this one, and will be printing
    <UNPREDICTABLE> for S > 10.
    
            * arm-dis.c (print_insn_cde): Wrap 'T' value.

Diff:
---
 opcodes/arm-dis.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/opcodes/arm-dis.c b/opcodes/arm-dis.c
index c1bf276b423..684c74f7f20 100644
--- a/opcodes/arm-dis.c
+++ b/opcodes/arm-dis.c
@@ -8957,7 +8957,7 @@ print_insn_cde (struct disassemble_info *info, long given, bool thumb)
 		    break;
 
 		  case 'T':
-		    func (stream, "%s", arm_regnames[value + 1]);
+		    func (stream, "%s", arm_regnames[(value + 1) & 15]);
 		    break;
 
 		  case 'd':

                 reply	other threads:[~2022-09-14  0:50 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220914005026.463EE395562E@sourceware.org \
    --to=amodra@sourceware.org \
    --cc=bfd-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).