public inbox for binutils-cvs@sourceware.org
 help / color / mirror / Atom feed
From: Alan Modra <amodra@sourceware.org>
To: bfd-cvs@sourceware.org
Subject: [binutils-gdb] PR29617, ld segfaults when bfd_close fails
Date: Tue, 27 Sep 2022 00:43:47 +0000 (GMT)	[thread overview]
Message-ID: <20220927004347.D429D3858D37@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=e122316b7ce78b999db944d7b524e11d642e2a49

commit e122316b7ce78b999db944d7b524e11d642e2a49
Author: Alan Modra <amodra@gmail.com>
Date:   Tue Sep 27 10:08:18 2022 +0930

    PR29617, ld segfaults when bfd_close fails
    
            PR 29617
            * ldmain.c (main): Don't access output_bfd after bfd_close.

Diff:
---
 ld/ldmain.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ld/ldmain.c b/ld/ldmain.c
index 1bbddaaad32..e676c3786a2 100644
--- a/ld/ldmain.c
+++ b/ld/ldmain.c
@@ -549,7 +549,7 @@ main (int argc, char **argv)
   else
     {
       if (!bfd_close (link_info.output_bfd))
-	einfo (_("%F%P: %pB: final close failed: %E\n"), link_info.output_bfd);
+	einfo (_("%F%P: %s: final close failed: %E\n"), output_filename);
 
       /* If the --force-exe-suffix is enabled, and we're making an
 	 executable file and it doesn't end in .exe, copy it to one

                 reply	other threads:[~2022-09-27  0:43 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220927004347.D429D3858D37@sourceware.org \
    --to=amodra@sourceware.org \
    --cc=bfd-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).