From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1386) id 583B53858427; Tue, 4 Oct 2022 07:41:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 583B53858427 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Jan Beulich To: bfd-cvs@sourceware.org Subject: [binutils-gdb] RISC-V: don't cast expressions' X_add_number to long in diagnostics X-Act-Checkin: binutils-gdb X-Git-Author: Jan Beulich X-Git-Refname: refs/heads/master X-Git-Oldrev: 09fbd1cf93bac1fe02860184f0a0bceedb40ff33 X-Git-Newrev: 021205d0219a5aa55e76fd19888b9c21ff3f4f3b Message-Id: <20221004074111.583B53858427@sourceware.org> Date: Tue, 4 Oct 2022 07:41:11 +0000 (GMT) X-BeenThere: binutils-cvs@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Oct 2022 07:41:11 -0000 https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3D021205d0219a= 5aa55e76fd19888b9c21ff3f4f3b commit 021205d0219a5aa55e76fd19888b9c21ff3f4f3b Author: Jan Beulich Date: Tue Oct 4 09:40:55 2022 +0200 RISC-V: don't cast expressions' X_add_number to long in diagnostics =20 There's no need for such workarounds anymore now that we use C99 uniformly. This addresses several testsuite failures encountered when (cross-)building on a 32-bit host. Diff: --- gas/config/tc-riscv.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/gas/config/tc-riscv.c b/gas/config/tc-riscv.c index f64b446bf11..98a954a2df0 100644 --- a/gas/config/tc-riscv.c +++ b/gas/config/tc-riscv.c @@ -3338,14 +3338,14 @@ riscv_ip (char *str, struct riscv_cl_insn *ip, expr= essionS *imm_expr, if (!sign) { if (!VALIDATE_U_IMM (imm_expr->X_add_number, n)) - as_bad (_("improper immediate value (%lu)"), - (unsigned long) imm_expr->X_add_number); + as_bad (_("improper immediate value (%"PRIu64")"), + imm_expr->X_add_number); } else { if (!VALIDATE_S_IMM (imm_expr->X_add_number, n)) - as_bad (_("improper immediate value (%li)"), - (long) imm_expr->X_add_number); + as_bad (_("improper immediate value (%"PRIi64")"), + imm_expr->X_add_number); } INSERT_IMM (n, s, *ip, imm_expr->X_add_number); imm_expr->X_op =3D O_absent;