public inbox for binutils-cvs@sourceware.org
 help / color / mirror / Atom feed
From: Tsukasa OI <a4lg@sourceware.org>
To: bfd-cvs@sourceware.org
Subject: [binutils-gdb] opcodes/riscv-dis.c: Remove last_map_state
Date: Fri, 14 Oct 2022 05:23:30 +0000 (GMT)	[thread overview]
Message-ID: <20221014052330.3DE3638582A0@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=637d7c14299eea2fbffb0e133ffe5e1883fbd43b

commit 637d7c14299eea2fbffb0e133ffe5e1883fbd43b
Author: Tsukasa OI <research_trasio@irq.a4lg.com>
Date:   Sat Aug 27 13:08:03 2022 +0000

    opcodes/riscv-dis.c: Remove last_map_state
    
    Before changing the core disassembler, we take care of minor code clarity
    issues and improve readability.
    
    This commit removes unused variable last_map_state (set by the
    print_insn_riscv function but not read anywhere else).
    
    opcodes/ChangeLog:
    
            * riscv-dis.c (last_map_state): Remove.
            (print_insn_riscv): Remove setting last_map_state.

Diff:
---
 opcodes/riscv-dis.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/opcodes/riscv-dis.c b/opcodes/riscv-dis.c
index 27e1978d428..daeb1b5fd15 100644
--- a/opcodes/riscv-dis.c
+++ b/opcodes/riscv-dis.c
@@ -64,7 +64,6 @@ struct riscv_private_data
 /* Used for mapping symbols.  */
 static int last_map_symbol = -1;
 static bfd_vma last_stop_offset = 0;
-enum riscv_seg_mstate last_map_state;
 
 /* Register names as used by the disassembler.  */
 static const char * const *riscv_gpr_names;
@@ -1041,8 +1040,6 @@ print_insn_riscv (bfd_vma memaddr, struct disassemble_info *info)
     set_default_riscv_dis_options ();
 
   mstate = riscv_search_mapping_symbol (memaddr, info);
-  /* Save the last mapping state.  */
-  last_map_state = mstate;
 
   /* Set the size to dump.  */
   if (mstate == MAP_DATA

                 reply	other threads:[~2022-10-14  5:23 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221014052330.3DE3638582A0@sourceware.org \
    --to=a4lg@sourceware.org \
    --cc=bfd-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).