public inbox for binutils-cvs@sourceware.org
 help / color / mirror / Atom feed
* [binutils-gdb] Fix an illegal memory access when parsing an ELF file containing corrupt symbol version information.
@ 2022-10-19 14:10 Nick Clifton
  0 siblings, 0 replies; only message in thread
From: Nick Clifton @ 2022-10-19 14:10 UTC (permalink / raw)
  To: bfd-cvs

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=5c831a3c7f3ca98d6aba1200353311e1a1f84c70

commit 5c831a3c7f3ca98d6aba1200353311e1a1f84c70
Author: Nick Clifton <nickc@redhat.com>
Date:   Wed Oct 19 15:09:12 2022 +0100

    Fix an illegal memory access when parsing an ELF file containing corrupt symbol version information.
    
            PR 29699
            * elf.c (_bfd_elf_slurp_version_tables): Fail if the sh_info field
            of the section header is zero.

Diff:
---
 bfd/ChangeLog | 6 ++++++
 bfd/elf.c     | 4 +++-
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index c618d817ff9..06501775453 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,9 @@
+2022-10-19  Nick Clifton  <nickc@redhat.com>
+
+	PR 29699
+	* elf.c (_bfd_elf_slurp_version_tables): Fail if the sh_info field
+	of the section header is zero.
+
 2022-09-09  Nick Clifton  <nickc@redhat.com>
 
 	PR 29532
diff --git a/bfd/elf.c b/bfd/elf.c
index fe00e0f9189..7cd7febcf95 100644
--- a/bfd/elf.c
+++ b/bfd/elf.c
@@ -8918,7 +8918,9 @@ _bfd_elf_slurp_version_tables (bfd *abfd, bool default_imported_symver)
 	  bfd_set_error (bfd_error_file_too_big);
 	  goto error_return_verref;
 	}
-      elf_tdata (abfd)->verref = (Elf_Internal_Verneed *) bfd_alloc (abfd, amt);
+      if (amt == 0)
+	goto error_return_verref;
+      elf_tdata (abfd)->verref = (Elf_Internal_Verneed *) bfd_zalloc (abfd, amt);
       if (elf_tdata (abfd)->verref == NULL)
 	goto error_return_verref;

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-10-19 14:10 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-19 14:10 [binutils-gdb] Fix an illegal memory access when parsing an ELF file containing corrupt symbol version information Nick Clifton

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).