public inbox for binutils-cvs@sourceware.org
 help / color / mirror / Atom feed
From: Andrew Burgess <aburgess@sourceware.org>
To: bfd-cvs@sourceware.org
Subject: [binutils-gdb] opcodes/arm: silence compiler warning about uninitialized variable use
Date: Fri,  4 Nov 2022 10:58:23 +0000 (GMT)	[thread overview]
Message-ID: <20221104105823.7AC76385841C@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=d8521074fe20928d34072701043806f381c5a07d

commit d8521074fe20928d34072701043806f381c5a07d
Author: Andrew Burgess <aburgess@redhat.com>
Date:   Fri Nov 4 10:46:59 2022 +0000

    opcodes/arm: silence compiler warning about uninitialized variable use
    
    After this commit:
    
      commit 6576bffe6cbbb53c5756b2fccd2593ba69b74cdf
      Date:   Thu Jul 7 13:43:45 2022 +0100
    
          opcodes/arm: add disassembler styling for arm
    
    Some people were seeing their builds failing with complaints about a
    possible uninitialized variable usage.  I previously fixed an instance
    of this issue in this commit:
    
      commit 2df82cd4b459fbc32120e0ad1ce19e26349506fe
      Date:   Tue Nov 1 10:36:59 2022 +0000
    
          opcodes/arm: silence compiler warning about uninitialized variable use
    
    which did fix the build problems that the sourceware buildbot was
    hitting, however, an additional instance of the same problem was
    brought to my attention, and that is fixed in this commit.
    
    Where commit 2df82cd4b4 fixed the uninitialized variable problem in
    print_mve_unpredictable, this commit fixes the same problem in
    print_mve_undefined.
    
    As with the previous commit, I don't believe we could really ever get
    an uninitialized variable usage, based on the current usage of the
    function, so I have just initialized the reason variable to "??".

Diff:
---
 opcodes/arm-dis.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/opcodes/arm-dis.c b/opcodes/arm-dis.c
index 31ed81f5a4e..47a0a38adec 100644
--- a/opcodes/arm-dis.c
+++ b/opcodes/arm-dis.c
@@ -7148,7 +7148,9 @@ print_mve_undefined (struct disassemble_info *info,
 {
   void *stream = info->stream;
   fprintf_styled_ftype func = info->fprintf_styled_func;
-  const char *reason;
+  /* Initialize REASON to avoid compiler warning about uninitialized
+     usage, though such usage should be impossible.  */
+  const char *reason = "??";
 
   switch (undefined_code)
     {

             reply	other threads:[~2022-11-04 10:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-04 10:58 Andrew Burgess [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-11-01 10:51 Andrew Burgess

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221104105823.7AC76385841C@sourceware.org \
    --to=aburgess@sourceware.org \
    --cc=bfd-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).