[binutils-gdb] fuzzed file timeout

[binutils-gdb] fuzzed file timeout

[Alan Modra]

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=3bba9d93294a8172018731477df72c1c3ef42136

commit 3bba9d93294a8172018731477df72c1c3ef42136
Author: Alan Modra <amodra@gmail.com>
Date:   Wed Jan 4 21:46:06 2023 +1030

    fuzzed file timeout
    
    objcopy of archive, element containing an object with a fuzzed section
    size far exceeding the element size.  copy_section detects this, but
    the temp file is laid out for the large section.  It can take a long
    time to write terabytes of sparse file, a waste of time when it will
    be deleted.
    
            * objcopy.c (copy_archive): Don't write element contents after
            bad status result from copy_object.

Diff:
---
 binutils/objcopy.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/binutils/objcopy.c b/binutils/objcopy.c
index a6182b48b6c..4d888906e67 100644
--- a/binutils/objcopy.c
+++ b/binutils/objcopy.c
@@ -3686,7 +3686,8 @@ copy_archive (bfd *ibfd, bfd *obfd, const char *output_target,
       if (!ok_object)
 	del = !copy_unknown_object (this_element, output_bfd);
 
-      if (!(ok_object && !del ? bfd_close : bfd_close_all_done) (output_bfd))
+      if (!(ok_object && !del && !status
+	    ? bfd_close : bfd_close_all_done) (output_bfd))
 	{
 	  bfd_nonfatal_message (output_name, NULL, NULL, NULL);
 	  /* Error in new object file. Don't change archive.  */